Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile-time support for VTK7.1 #1770

Merged
merged 1 commit into from
Jan 5, 2017

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Dec 3, 2016

The *TupleValue function family got removed in favor of the *TypedTuple functions.

To preserve backward compatibility with older VTK versions,
this introduces local macro-overloads for the used functions.

@taketwo
Copy link
Member

taketwo commented Dec 4, 2016

The condition for ifdefs looks mysterious. Is this some file that was added in recent versions? Why not an explicit version check?

@v4hn
Copy link
Contributor Author

v4hn commented Dec 7, 2016

Hey @taketwo,

I took the condition from the VTK Wiki examples where they are used in a couple of places.
I assume they know what they're doing.

@v4hn
Copy link
Contributor Author

v4hn commented Dec 23, 2016

ping?

The *TupleValue function family got removed in favor of the *TypedTuple functions.

To preserve backward compatibility with older VTK versions,
this introduces local macro-overloads for the used functions.
@jspricke jspricke merged commit ad67293 into PointCloudLibrary:master Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants