Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid cast to LeafNode* in OctreePointCloudVoxelCentroid #1700

Merged

Conversation

SergioRAgostinho
Copy link
Member

Closes #960. Credits to @ThomasGuerneve for the original PR.

@SergioRAgostinho SergioRAgostinho added the needs: code review Specify why not closed/merged yet label Aug 26, 2016
@SergioRAgostinho SergioRAgostinho added this to the pcl-1.8.1 milestone Aug 26, 2016
@taketwo taketwo removed the needs: code review Specify why not closed/merged yet label Aug 26, 2016
@taketwo taketwo merged commit f9f0ea8 into PointCloudLibrary:master Aug 26, 2016
@SergioRAgostinho
Copy link
Member Author

The build failed. Let me have a look at it.

@taketwo
Copy link
Member

taketwo commented Aug 26, 2016

It's unrelated. IIRC the failing test is due to random nature of the algorithm being tested (KFPCS).
See #1229. (Are we in 0.01% today? :) )

@SergioRAgostinho
Copy link
Member Author

That's why RNGesus created seeds :) Just ran the test 5 times on my env and it's passing. I assume it might be failing sporadically then. I'll try to see if I can make the test consistent.

Nevertheless, can you give it a try on your linuv env as well? Just want to be sure this is an rng issue and not some something related to platform difference.

@taketwo
Copy link
Member

taketwo commented Aug 26, 2016

Succeeded 10 times in a row on my machine.

@SergioRAgostinho
Copy link
Member Author

(Are we in 0.01% today? :) )

Hahaha. (buys lottery ticket)

Thanks for the tests. I just figured out I won't be able to do much without doing changes to the api because the seed is reset to srand (time (NULL)) in some of the methods.

@SergioRAgostinho SergioRAgostinho deleted the oct-get-voxel-at-point branch December 21, 2016 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants