Fix issue #1695. Test for parallel planes in planePlaneIntersection. #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please have a look at the failing unit test. |
|
Sorry @sand-box. Seems like I induced you in error in the other post. :D I think we also need to look only into the absolute value of the angular tolerante on that check. Because if they provide you with negative values that condition will always be false. Other than that LGTM 👍 Don't forget to squash the commits at the end. |
…aneIntersection.
sand-box
force-pushed
the
intersection_fix
branch
from
379f37d
to
8e8a778
Compare
|
@SergioRAgostinho No problem. |
SergioRAgostinho
removed
the
needs: author reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.