Inherit StatisticalOutlierRemoval<PCLPointCloud2> from FilterIndices - #1663
Merged
taketwo merged 3 commits intoSep 2, 2017
Merged
Conversation
stefanbuettner
force-pushed
the
OrganizedStatisticalOutlierRemoval
branch
from
July 28, 2016 15:38
a6c59cf to
a4e0157
Compare
Member
|
|
UnaNancyOwen
pushed a commit
to UnaNancyOwen/pcl
that referenced
this pull request
Nov 24, 2017
…ry#1663) Inherit from FilterIndices and implement applyFilter, move duplicate code
taketwo
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all,
recently I was very happy to see that there are specializations of many algorithms for
PCLPointCloud2. However, theStatisticalOutlierRemoval<PCLPointCloud2>class inherits fromFilter<PCLPointCloud2>as opposed to theStatisticalOutlierRemoval<PointT>which inherits fromFilterIndices<PointT>. In contrast to theFilterclass,FilterIndicessupports keeping the cloud organized apart from only returning an index list of the good points, of course.This PR suggests a change from the
Filter<PCLPointCloud2>base class to theFilterIndices<PCLPointCloud2>base class allowing to keep the point cloud organized and to filter only the indices.What do you think?
I still need to squash.
Best,
Stefan