Inherit StatisticalOutlierRemoval<PCLPointCloud2> from FilterIndices #1663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all,
recently I was very happy to see that there are specializations of many algorithms for
PCLPointCloud2
. However, theStatisticalOutlierRemoval<PCLPointCloud2>
class inherits fromFilter<PCLPointCloud2>
as opposed to theStatisticalOutlierRemoval<PointT>
which inherits fromFilterIndices<PointT>
. In contrast to theFilter
class,FilterIndices
supports keeping the cloud organized apart from only returning an index list of the good points, of course.This PR suggests a change from the
Filter<PCLPointCloud2>
base class to theFilterIndices<PCLPointCloud2>
base class allowing to keep the point cloud organized and to filter only the indices.What do you think?
I still need to squash.
Best,
Stefan