Simulation: more access to camera parameters #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienjadeduff
changed the title
| @@ -145,6 +164,18 @@ namespace pcl | |||
| const float* | |||
| getScoreBuffer (); | |||
|
|
|||
| float | |||
| getZNear(){ return z_near_; } | |||
There was a problem hiding this comment.
Space before opening parenthesis.
|
Hey damienjadeduff, firstly, I think that's a good approach you're following there 👍 Cheers, |
SergioRAgostinho
added
status: ready to merge
and removed
status: ready to merge
labels
|
Please squash the commits into a single one. |
damienjadeduff
force-pushed
the
pull_request_cam_params
branch
from
5fb3ec1
to
2d5c42a
Compare
|
I made the requested white-space changes and squashed the commits. I made an assumption about the 2nd request and changed the pre-existing set() function in the same way. Regards. |
|
Looks good to me |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives the user of the simulation module the ability to retrieve camera parameters and also to set the clipping planes, which earlier were set to arbitrary values.
We are using the simulation module in its current state and we expect others are too.
Kind regards.