Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update find boost of cmake macro for support the latest versions #1630

Merged
merged 1 commit into from
Jun 30, 2016

Conversation

UnaNancyOwen
Copy link
Member

@UnaNancyOwen UnaNancyOwen commented Jun 13, 2016

This pull request will update find_boost() cmake macro for support the latest versions (1.48.0 - 1.61.0) of boost.
In Addition, Automatically adds the boost version that was used when building the PCL to PCLConfig.cmake.
This change will facilitate future management.

@stefanbuettner
Copy link
Contributor

👍 for adding the boost version with which PCL was compiled.
But why are all the other boost versions listed individually? Just curious.

@SergioRAgostinho
Copy link
Member

@UnaNancyOwen Correct me if, I'm wrong. So the idea here is, if you provide the major, minor and subminor versions, these are selected first, otherwise it will try to grab the highest boost version of all the ones you've listed. Also, you've added the more recent boost versions to the list. Is this it?

Small remark: I don't think this PR is really worth three commits and would recommend to squash them into a single one.

Update find boost macro.
Automatic addition of boost version that was used when building the PCL to PCLConfig.cmake.
@UnaNancyOwen
Copy link
Member Author

UnaNancyOwen commented Jun 23, 2016

I was squash the commits.

pcl_find_boost.cmake requires listed versions for find latest version.
PCLConfig.cmake basically requires find Boost that was used when building the PCL.
If it is not found, find latest version that listed in config file.

CMake can't find the new version than the versions that has been defined in FindBoost of CMake.
But, CMake can find the versions that are listed in the "Boost_ADDITIONAL_VERSIONS".
This change will prevents the problem that can't find Boost, when the user to use the old CMake.

What do you think?

@SergioRAgostinho
Copy link
Member

I was squash the commits.

Thanks

pcl_find_boost.cmake requires listed versions for find latest version.
PCLConfig.cmake basically requires find Boost that was used when building the PCL.
If it is not found, find latest version that listed in config file.

So this one get's used by projects linking agains pcl. Makes sense to use the same version yes.

CMake can't find the new version than the versions that has been defined in FindBoost of CMake.
But, CMake can find the versions that are listed in the "Boost_ADDITIONAL_VERSIONS".
This change will prevents the problem that can't find Boost, when the user to use the old CMake.

Took me a while to realise that the FindBoost file you linked was in Kitware's CMake repo ^_^ So yes, this adds the latest Boost versions to old CMake versions the users might be running.

👍 Good to go for me. Will merge in a couple of days if no one opposes.

@SergioRAgostinho SergioRAgostinho merged commit e3374cc into PointCloudLibrary:master Jun 30, 2016
animecomico pushed a commit to animecomico/pcl that referenced this pull request Aug 18, 2016
Update find boost of cmake macro for support the latest versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants