Prevent building PCL with VTK and OpenGL2 backend #1533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -362,6 +362,14 @@ if(WITH_VTK AND NOT ANDROID) | |||
| find_package(VTK) | |||
| if(VTK_FOUND) | |||
| message(STATUS "VTK_MAJOR_VERSION ${VTK_MAJOR_VERSION}") | |||
| if (NOT "${VTK_RENDERING_BACKEND}" STREQUAL "OpenGL") | |||
There was a problem hiding this comment.
Where you expect this variable to come from?
There was a problem hiding this comment.
VTK! It is set by the VTK CMake script in newer VTK versions:
$ sudo grep -i "VTK_RENDERING_BACKEND" /opt/vtk7_opengl2/lib/cmake/vtk-7.1 -r
/opt/vtk7_opengl2/lib/cmake/vtk-7.1/VTKConfig.cmake:set(VTK_RENDERING_BACKEND "OpenGL2")
/opt/vtk7_opengl2/lib/cmake/vtk-7.1/vtkGroups.cmake: if(${group} MATCHES "^Rendering" AND "None" STREQUAL VTK_RENDERING_BACKEND)
This variable does not exist in VTK 5.8 release so I changed the condition to handle that case.
Still, VTK is not disabled when OpenGL2 is detected (I get the warning message though).
|
Not needed thanks to #1534. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is here but the
WITH_VTKflag is not disabled. Ideas?