Update OpenNI2 grabber to support devices without color #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for testing taketwo. What's wrong with merging #1174 (after cleaning it up)? Otherwise I would propose to at least attribute this patch to metacomgd. |
|
The rest of the original PR is not ready for merging. Changes to I refer to the author's GitHub name in the commit message. Do you want something different? |
|
Thanks for the clarification. I think the usual way would be to leave the author field in place, as it contains more then the Github name. |
This commit contains a subset of changes proposed by @metacomgd in PointCloudLibrary#1174.
taketwo
force-pushed
the
openni2-without-color
branch
from
18e1bce
to
85eb7ba
Compare
|
Changed the author of the commit. |
jspricke
added a commit
that referenced
this pull request
Oct 11, 2015
Update OpenNI2 grabber to support devices without color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a subset of changes proposed by @metacomgd in #1174. It has been reported to work reliably with Structure.io sensor. From my side I can confirm that it does not affect streaming of depth+color data from Asus.