Fix to pcl::io::load and pcl::io::save #1294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the template methods
pcl::io::load
andpcl::io::save
was inpcl/io/src/file_io.cpp
. Not only was this not conforming with pcl style guide, bit it also rendered the methods useless, since the compiler could not find the appropriate symbols.I just moved the code around between files and edited the CMakeLists.txt and now everything should be ok.
Edit: I now noticed that the proper way to do this is to mimic what was done in pcd_io.h and pcd_io.hpp, but right now that creates a circular reference.