-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added method to get point indices from convex_hull #1213
Conversation
@@ -166,6 +166,14 @@ namespace pcl | |||
return (dimension_); | |||
} | |||
|
|||
/** \brief Retriev the indices of the input point cloud that for the convex hull. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retrieve
cloud that for the
👍 for the idea. Perhaps we could add the same method to concave hull? |
Added the method for concave hull in the last commit |
Thanks! Is there any specific reason why you use a combination of |
I think it becomes slightly more clear that with calling |
No, just wondering. You are the author, let's keep your preferred version. Could you please squash the commits into a single one? Then I'll merge. |
@SvenAlbrecht: The way you copy the PointIndices structure ignores the PCLHeader that is (/should be) included. So please add the header of the input cloud there before returning the indices. |
@v4hn Good point - I honestly didn't think of that. Fix will come soon. |
- Added method 'getHullPointIndices ()' in 'pcl::ConvexHull' and 'pcl::ConcaveHull' to retrieve the indices of the input cloud that compose the hull. This might be helpful if the input point cloud is organized the hull needs to be retrieved while retaining the underlying organization of the point cloud data. - Point indices are stored via new member of type pcl::PointIndices
looks good now, @SvenAlbrecht thanks! |
Added method to get point indices from convex_hull
input point cloud that form its convex hull. In some cases it is
more convenient to work with convex hull in form of the points from
the input point cloud (for example when it is organized) than with a
new point cloud containing only the geometric information, but not
the organization.