fix bugs in renderView #1026
Merged
fix bugs in renderView #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat2 should applied before y,z axis flipping
|
Looks okay. Should we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mat2 should applied before y,z axis flipping
If you look at the original code, world_coords[0], world_coods[1], world_coods[2] has been normalized by
world_coords[3], but itself not normalized to 1.0f. Then mat2 is applied to world_coods directly, so you will get distored result. See my closed pull request #1015.
On the other hand, y or z axis flipping operation should be applied after mat2.