Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed registration mode and color integration when passing pcd files for pcl_kinfu_app #1018

Merged
merged 1 commit into from
Dec 14, 2014

Conversation

msalvato
Copy link
Contributor

Previous to this fix when using registration mode with the -pcd flag in pcl_kinfu_app, the View3D from ray tracing window would be entirely black. Work largely ported from kinfu_large_scale.

@@ -703,8 +703,6 @@ struct KinFuApp
{
registration_ = capture_.providesCallback<pcl::ONIGrabber::sig_cb_openni_image_depth_image> ();
cout << "Registration mode: " << (registration_ ? "On" : "Off (not supported by source)") << endl;
if (registration_)
kinfu_.setDepthIntrinsics(KINFU_DEFAULT_RGB_FOCAL_X, KINFU_DEFAULT_RGB_FOCAL_Y);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably shouldn't. Readded it.

@msalvato msalvato force-pushed the master branch 8 times, most recently from 9777ad1 to 3dadd50 Compare November 26, 2014 23:05
taketwo added a commit that referenced this pull request Dec 14, 2014
Fixed registration mode and color integration when passing pcd files for pcl_kinfu_app
@taketwo taketwo merged commit fe33c8f into PointCloudLibrary:master Dec 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants