Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add and deprecate pcl_isnan, pcl_isfinite, and pcl_isinf to avoid API breakage #3444

Closed
taketwo opened this issue Oct 29, 2019 · 2 comments · Fixed by #3457
Closed

Re-add and deprecate pcl_isnan, pcl_isfinite, and pcl_isinf to avoid API breakage #3444

taketwo opened this issue Oct 29, 2019 · 2 comments · Fixed by #3457
Milestone
pcl-1.10.0

Comments

@taketwo
Copy link
Member

taketwo commented Oct 29, 2019

#2798 removed several public API functions without first deprecating them. We should re-introduce these functions before tagging 1.10 release.
@taketwo taketwo added this to the pcl-1.10.0 milestone Oct 29, 2019
@taketwo taketwo mentioned this issue Oct 29, 2019
Merged
@kunaltyagi
Copy link
Member

Is this correct? Seems fishy to me. Maybe the commit message referenced wrong issue?

@SergioRAgostinho
Copy link
Member

It does look fishy. Let's reopen.

@SergioRAgostinho SergioRAgostinho mentioned this issue Nov 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
pcl-1.10.0
Development

Successfully merging a pull request may close this issue.

Deprecate pcl_isnan, pcl_isfinite and pcl_isinf properly SergioRAgostinho/pcl
3 participants
@taketwo @SergioRAgostinho @kunaltyagi