Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in compound target generation #3089

Closed
SergioRAgostinho opened this issue May 17, 2019 · 0 comments · Fixed by #3090
Closed

Regression in compound target generation #3089

SergioRAgostinho opened this issue May 17, 2019 · 0 comments · Fixed by #3090
Labels
Milestone

Comments

@SergioRAgostinho
Copy link
Member

The PR #3044 introduced a regression in #2673. By turning cmake macros into functions, it modified the previous existing variable scope and broke the compound target generation mechanism.

The current possible options are:

  • I believe looking into the parent scope as in set(target_list ${target_list} ${new_target} PARENT_SCOPE) might be sufficient, but prone to break if we rearrange our scripts further
  • Use INTERNAL CACHE variables - This persists over runs, so if the user decides to changes the which targets he wants built half way through configuration, this variable will not reflect the most current state.
  • Use GLOBAL PROPERTIES - I suspect this one might face the same persistence issue as the INTERNAL CACHE
  • revert back from function to macro - These target creation routines are not defining temporary variables inside, so there's no penalty in doing so. Suffers from the same breakage risk as the first option, with respect to future changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant