Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General replacement of push_back for emplace_back where appropriate. #2202

Closed
svenevs opened this issue Feb 3, 2018 · 2 comments · Fixed by #2784
Closed

General replacement of push_back for emplace_back where appropriate. #2202

svenevs opened this issue Feb 3, 2018 · 2 comments · Fixed by #2784
Assignees

Comments

@svenevs
Copy link
Contributor

svenevs commented Feb 3, 2018

@SergioRAgostinho can you delete the card you put on the migration project and "convert this issue to a card" instead? That will enable a conversation to be attached.

I am indebted to PCL, and am happy to slowly whittle away at this. Having it as an issue will make it easier for you all to ping me on this issue after 1.9 is out and hash out the ideal work-flow (e.g. I fork off an emplace_back branch and continually re-base?).

@SergioRAgostinho
Copy link
Member

Thanks. Done.

I'll ping you once we enable the flags. I'm gonna assign this to you in the meantime.

@SergioRAgostinho
Copy link
Member

You can kick it off if you feel like it. The flags are already merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants