Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide proper depreciation to EuclideanClusterComparator #2091

Closed
SergioRAgostinho opened this issue Nov 16, 2017 · 3 comments
Closed

Provide proper depreciation to EuclideanClusterComparator #2091

SergioRAgostinho opened this issue Nov 16, 2017 · 3 comments
Labels
changelog: ABI break Meta-information for changelog generation
Milestone

Comments

@SergioRAgostinho
Copy link
Member

Following up on the discussion of #1542 (comment)

@SergioRAgostinho SergioRAgostinho added the changelog: API break Meta-information for changelog generation label Nov 16, 2017
@SergioRAgostinho SergioRAgostinho added this to the pcl-1.9.0 milestone Nov 16, 2017
@taketwo
Copy link
Member

taketwo commented Nov 16, 2017

I am not aware of any proper way to deprecate the removed template parameter, so I think we will break API anyway.

But of course, It would be nice to add depreciation warnings to removed functions. The user will see a compiler error (because of mismatched template list) and these warnings from follow-up function calls. So perhaps it would be handy to put a note about what happened with template parameters in these warnings.

@SergioRAgostinho
Copy link
Member Author

we can leave the template parameter there and remove it in the future.

@SergioRAgostinho SergioRAgostinho added changelog: ABI break Meta-information for changelog generation and removed changelog: API break Meta-information for changelog generation labels Nov 16, 2017
@taketwo
Copy link
Member

taketwo commented Nov 16, 2017

True. So when users use deprecated functions they will be warned both about the functions themselves and about the future template parameter removal. Sounds good for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: ABI break Meta-information for changelog generation
Projects
None yet
Development

No branches or pull requests

2 participants