Skip to content

setCameraParameters() window size math #1610

Closed

Description

@samarth-robo

This issue has been posted to the mailing list too: http://www.pcl-users.org/PCL-Visualizer-setCameraParameters-math-td4041757.html

The window size is calculated from the intrinsics matrix at https://github.com/PointCloudLibrary/pcl/blob/master/visualization/src/interactor_style.cpp#L230 as:
// Get the width and height of the image - assume the calibrated centers are at the center of the image
Eigen::Vector2i window_size;
window_size[0] = static_cast<int> (intrinsics (0, 2));
window_size[1] = static_cast<int> (intrinsics (1, 2));

Since the 'calibrated centers are at the center of the image', this seems wrong to me. It seems to me that the window size must be 2 * camera center.

Activity

  1. changed the title [-]`setCameraParameters()` window size math[/-] [+]setCameraParameters() window size math[/+] on May 20, 2016
  2. SergioRAgostinho commented on May 23, 2016

    @SergioRAgostinho
    Member

    Makes sense. Come up with simple test case so that we can verify it quickly and submit a pull request please.

  3. taketwo commented on Aug 25, 2016

    @taketwo
    Member

    Can we close this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions