Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setCameraParameters() window size math #1610

Closed
samarth-robo opened this issue May 20, 2016 · 2 comments
Closed

setCameraParameters() window size math #1610

samarth-robo opened this issue May 20, 2016 · 2 comments

Comments

@samarth-robo
Copy link
Contributor

samarth-robo commented May 20, 2016

This issue has been posted to the mailing list too: http://www.pcl-users.org/PCL-Visualizer-setCameraParameters-math-td4041757.html

The window size is calculated from the intrinsics matrix at https://github.com/PointCloudLibrary/pcl/blob/master/visualization/src/interactor_style.cpp#L230 as:
// Get the width and height of the image - assume the calibrated centers are at the center of the image
Eigen::Vector2i window_size;
window_size[0] = static_cast<int> (intrinsics (0, 2));
window_size[1] = static_cast<int> (intrinsics (1, 2));

Since the 'calibrated centers are at the center of the image', this seems wrong to me. It seems to me that the window size must be 2 * camera center.

@samarth-robo samarth-robo changed the title setCameraParameters() window size math setCameraParameters() window size math May 20, 2016
@SergioRAgostinho
Copy link
Member

Makes sense. Come up with simple test case so that we can verify it quickly and submit a pull request please.

@taketwo
Copy link
Member

taketwo commented Aug 25, 2016

Can we close this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants