Merge pull request #2082 from SergioRAgostinho/more-warnings

Suppress the final set of warnings in pcl apps

Author: taketwo

apps/3d_rec_framework/include/pcl/apps/3d_rec_framework/pipeline/impl/global_nn_recognizer_cvfh.hpp

@@ -295,7 +295,7 @@ template<template<class > class Distance, typename PointInT, typename FeatureT>
               nearestKSearch (single_categories_index_[it->second], histogram, NN_, indices, distances);
               //gather NN-search results
               double score = 0;
-              for (size_t i = 0; i < NN_; ++i)
+              for (size_t i = 0; i < (size_t) NN_; ++i)
               {
                 score = distances[0][i];
                 index_score is;

apps/3d_rec_framework/include/pcl/apps/3d_rec_framework/utils/metrics.h

@@ -121,7 +121,7 @@ namespace Metrics
        */
       template<typename U, typename V>
         inline ResultType
-        accum_dist (const U& a, const V& b, int dim) const
+        accum_dist (const U& a, const V& b, int) const
         {
           //printf("New code being used, accum_dist\n");
           ResultType min0;

apps/3d_rec_framework/tools/apps/src/local_recognition_mian_dataset.cpp

@@ -117,7 +117,7 @@ template<template<class > class DistT, typename PointT, typename FeatureT>
       {
         std::cout << files[i] << std::endl;
         if (scene != -1)
-          if (scene != i)
+          if ((size_t) scene != i)
             continue;
 
         std::stringstream file;

apps/cloud_composer/include/pcl/apps/cloud_composer/tools/impl/organized_segmentation.hpp

@@ -105,7 +105,7 @@
 
      boost::shared_ptr<std::map<uint32_t, bool> > plane_labels = boost::make_shared<std::map<uint32_t, bool> > ();
      for (size_t i = 0; i < label_indices.size (); ++i)
-       (*plane_labels)[i] = (label_indices[i].indices.size () > min_plane_size);
+       (*plane_labels)[i] = (label_indices[i].indices.size () > (size_t) min_plane_size);
      typename PointCloud<PointT>::CloudVectorType clusters;
 
      typename EuclideanClusterComparator<PointT, pcl::Label>::Ptr euclidean_cluster_comparator = boost::make_shared <EuclideanClusterComparator<PointT, pcl::Label> > ();
@@ -123,7 +123,7 @@
      pcl::IndicesPtr extracted_indices (new std::vector<int> ());
      for (size_t i = 0; i < euclidean_label_indices.size (); i++)
      {
-       if (euclidean_label_indices[i].indices.size () >= min_cluster_size)
+       if (euclidean_label_indices[i].indices.size () >= (size_t) min_cluster_size)
        {
          typename PointCloud<PointT>::Ptr cluster = boost::shared_ptr<PointCloud<PointT> > (new PointCloud<PointT>);
          pcl::copyPointCloud (*input_cloud,euclidean_label_indices[i].indices,*cluster);
@@ -138,7 +138,7 @@
 
      for (size_t i = 0; i < label_indices.size (); i++)
      {
-       if (label_indices[i].indices.size () >= min_plane_size)
+       if (label_indices[i].indices.size () >= (size_t) min_plane_size)
        {
          typename PointCloud<PointT>::Ptr plane = boost::shared_ptr<PointCloud<PointT> > (new PointCloud<PointT>);
          pcl::copyPointCloud (*input_cloud,label_indices[i].indices,*plane);

apps/cloud_composer/tools/organized_segmentation.cpp

@@ -31,7 +31,7 @@ pcl::cloud_composer::OrganizedSegmentationTool::performAction (ConstItemList inp
 {
   if (type != PointTypeFlags::NONE)
   {
-    switch (type)
+    switch ((uint8_t) type)
     {
       case (PointTypeFlags::XYZ):
         return this->performTemplatedAction<pcl::PointXYZ> (input_data);

apps/cloud_composer/tools/supervoxels.cpp

@@ -29,7 +29,7 @@ pcl::cloud_composer::SupervoxelsTool::performAction (ConstItemList input_data, P
 {
   if (type != PointTypeFlags::NONE)
   {
-    switch (type)
+    switch ((uint8_t) type)
     {
       case (PointTypeFlags::XYZ | PointTypeFlags::RGB):
         return this->performTemplatedAction<pcl::PointXYZRGB> (input_data);

apps/in_hand_scanner/src/icp.cpp

@@ -244,7 +244,7 @@ pcl::ihs::ICP::findTransformation (const MeshConstPtr&              mesh_model,
       // Check the distance threshold
       if (squared_distance [0] < squared_distance_threshold)
       {
-        if (index [0] >= cloud_model_selected->size ())
+        if ((size_t) index [0] >= cloud_model_selected->size ())
         {
           std::cerr << "ERROR in icp.cpp: Segfault!\n";
           std::cerr << "  Trying to access index " << index [0] << " >= " << cloud_model_selected->size () << std::endl;

apps/in_hand_scanner/src/mesh_processing.cpp

@@ -93,7 +93,7 @@ pcl::ihs::MeshProcessing::processBoundary (Mesh& mesh, const std::vector <HalfEd
       //                  \ /          //
       //                   5           //
 
-      for (int i=0; i<boundary.size (); ++i)
+      for (size_t i=0; i<boundary.size (); ++i)
       {
         // The vertices on the boundary
         vi_a = mesh.getOriginatingVertexIndex (boundary [i]);

apps/modeler/src/parameter_dialog.cpp

@@ -156,7 +156,7 @@ pcl::modeler::Parameter* pcl::modeler::ParameterDelegate::getCurrentParameter(co
   std::map<std::string, Parameter*>::iterator currentParameter = parameter_map_.begin();
 
   size_t currentRow = 0;
-  while(currentRow < index.row() && currentParameter != parameter_map_.end()) {
+  while(currentRow < (size_t) index.row() && currentParameter != parameter_map_.end()) {
     ++ currentParameter;
     ++ currentRow;
   }

tracking/include/pcl/tracking/impl/pyramidal_klt.hpp

@@ -512,8 +512,8 @@ pcl::tracking::PyramidalKLTTracker<PointInT, IntensityT>::track (const PointClou
       iprev_point[0] = floor (prev_pt[0]);
       iprev_point[1] = floor (prev_pt[1]);
 
-      if (iprev_point[0] < -track_width_ || iprev_point[0] >= grad_x.width ||
-          iprev_point[1] < -track_height_ || iprev_point[1] >= grad_y.height)
+      if (iprev_point[0] < -track_width_ || (uint32_t) iprev_point[0] >= grad_x.width ||
+          iprev_point[1] < -track_height_ || (uint32_t) iprev_point[1] >= grad_y.height)
       {
         if (level == 0)
           status [ptidx] = -1;
@@ -544,13 +544,13 @@ pcl::tracking::PyramidalKLTTracker<PointInT, IntensityT>::track (const PointClou
       next_pt -= half_win;
 
       Eigen::Array2f prev_delta;
-      for (int j = 0; j < max_iterations_; j++)
+      for (unsigned int j = 0; j < max_iterations_; j++)
       {
         inext_pt[0] = floor (next_pt[0]);
         inext_pt[1] = floor (next_pt[1]);
 
-        if (inext_pt[0] < -track_width_ || inext_pt[0] >= next.width ||
-            inext_pt[1] < -track_height_ || inext_pt[1] >= next.height)
+        if (inext_pt[0] < -track_width_ || (uint32_t) inext_pt[0] >= next.width ||
+            inext_pt[1] < -track_height_ || (uint32_t) inext_pt[1] >= next.height)
         {
           if (level == 0)
             status[ptidx] = -1;
@@ -595,8 +595,8 @@ pcl::tracking::PyramidalKLTTracker<PointInT, IntensityT>::track (const PointClou
         inext_point[0] = floor (next_point[0]);
         inext_point[1] = floor (next_point[1]);
 
-        if (inext_point[0] < -track_width_ || inext_point[0] >= next.width ||
-            inext_point[1] < -track_height_ || inext_point[1] >= next.height)
+        if (inext_point[0] < -track_width_ || (uint32_t) inext_point[0] >= next.width ||
+            inext_point[1] < -track_height_ || (uint32_t) inext_point[1] >= next.height)
         {
           status[ptidx] = -1;
           continue;