From a4dfb3f677a081b9692cf683fab02a1f7c2bc62b Mon Sep 17 00:00:00 2001 From: Larshg Date: Wed, 6 May 2020 08:04:19 +0200 Subject: [PATCH 1/2] Add comment to why and what is tested. --- test/visualization/test_visualization.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/visualization/test_visualization.cpp b/test/visualization/test_visualization.cpp index 9cd48adefdd..0d95a6e85f4 100644 --- a/test/visualization/test_visualization.cpp +++ b/test/visualization/test_visualization.cpp @@ -61,6 +61,8 @@ PointCloud::Ptr cloud_with_normals1 (new PointCloud); search::KdTree::Ptr tree3; search::KdTree::Ptr tree4; +// Test that updatepointcloud works when removing points. Ie. modifying vtkdata to reflect modified pointcloud +// See #4001 and #3452 for previously undetected error. //////////////////////////////////////////////////////////////////////////////// TEST(PCL, PCLVisualizer_updatePointCloud) { From 7b13655e6ad4a823da47b9cbb710d84c55576ca6 Mon Sep 17 00:00:00 2001 From: Larshg Date: Wed, 6 May 2020 08:11:56 +0200 Subject: [PATCH 2/2] reword, so it doesn't sound like an explicit vtkdata type, but in more general terms. --- test/visualization/test_visualization.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/visualization/test_visualization.cpp b/test/visualization/test_visualization.cpp index 0d95a6e85f4..b34c30d5521 100644 --- a/test/visualization/test_visualization.cpp +++ b/test/visualization/test_visualization.cpp @@ -61,7 +61,7 @@ PointCloud::Ptr cloud_with_normals1 (new PointCloud); search::KdTree::Ptr tree3; search::KdTree::Ptr tree4; -// Test that updatepointcloud works when removing points. Ie. modifying vtkdata to reflect modified pointcloud +// Test that updatepointcloud works when removing points. Ie. modifying vtk data structure to reflect modified pointcloud // See #4001 and #3452 for previously undetected error. //////////////////////////////////////////////////////////////////////////////// TEST(PCL, PCLVisualizer_updatePointCloud)