Merge pull request #2556 from SergioRAgostinho/suppress-warnings

Suppress miscelanious warnings
PointCloudLibrary · Oct 14, 2018 · 5783aa0 · 5783aa0
2 parents 5efd95a + 2ac5f85
commit 5783aa0
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 7 deletions.
diff --git a/apps/cloud_composer/src/properties_model.cpp b/apps/cloud_composer/src/properties_model.cpp
@@ -111,7 +111,6 @@ pcl::cloud_composer::PropertiesModel::copyProperties (const PropertiesModel* to_
   for (int i=0; i < to_copy->rowCount (); ++i){
     QList <QStandardItem*> new_row;
     QStandardItem* parent = to_copy->item(i,0);
-    QModelIndex parent_index = to_copy->index(i,0);
     qDebug () << "Copying "<<parent->text()<< " cols ="<<to_copy->columnCount ();
     new_row.append (parent->clone ());
     for (int j=1; j < to_copy->columnCount (); ++j)

diff --git a/io/src/dinast_grabber.cpp b/io/src/dinast_grabber.cpp
@@ -125,8 +125,12 @@ pcl::DinastGrabber::setupDevice (int device_position, const int id_vendor, const
     sstream << "[pcl::DinastGrabber::setupDevice] libusb initialization failure, LIBUSB_ERROR: "<< ret;
     PCL_THROW_EXCEPTION (pcl::IOException, sstream.str ());
   }
-
-  libusb_set_debug (context_, 3);
+
+  #if defined(LIBUSB_API_VERSION) && (LIBUSB_API_VERSION >= 0x01000106)
+    libusb_set_option (context_, LIBUSB_OPTION_LOG_LEVEL, 3);
+  #else
+    libusb_set_debug (context_, 3);
+  #endif
   libusb_device **devs = NULL;
 
   // Get the list of USB devices

diff --git a/io/src/obj_io.cpp b/io/src/obj_io.cpp
@@ -395,7 +395,7 @@ pcl::OBJReader::readHeader (const std::string &file_name, pcl::PCLPointCloud2 &c
       if (line[0] == 'v')
       {
         // Vertex (v)
-        if ((line[1] == ' ')) {
+        if (line[1] == ' ') {
           ++nr_point;
           continue;
         }

diff --git a/io/src/pcd_io.cpp b/io/src/pcd_io.cpp
@@ -373,7 +373,7 @@ pcl::PCDReader::readHeader (std::istream &fs, pcl::PCLPointCloud2 &cloud,
     }
   }
 
-  if (int (cloud.width * cloud.height) != nr_points)
+  if (cloud.width * cloud.height != nr_points)
   {
     PCL_ERROR ("[pcl::PCDReader::readHeader] HEIGHT (%d) x WIDTH (%d) != number of points (%d)\n", cloud.height, cloud.width, nr_points);
     return (-1);

diff --git a/registration/include/pcl/registration/impl/ia_kfpcs.hpp b/registration/include/pcl/registration/impl/ia_kfpcs.hpp
@@ -83,7 +83,7 @@ pcl::registration::KFPCSInitialAlignment <PointSource, PointTarget, NormalT, Sca
 
   // generate a subset of indices of size ransac_iterations_ on which to evaluate candidates on
   std::size_t nr_indices = indices_->size ();
-  if (nr_indices < ransac_iterations_)
+  if (nr_indices < size_t (ransac_iterations_))
     indices_validation_ = indices_;
   else
     for (int i = 0; i < ransac_iterations_; i++)

diff --git a/surface/include/pcl/surface/impl/concave_hull.hpp b/surface/include/pcl/surface/impl/concave_hull.hpp
@@ -242,7 +242,7 @@ pcl::ConcaveHull<PointInT>::performReconstruction (PointCloud &alpha_shape, std:
   int max_vertex_id = 0;
   FORALLvertices
   {
-    if (vertex->id + 1 > max_vertex_id)
+    if (vertex->id + 1 > unsigned (max_vertex_id))
       max_vertex_id = vertex->id + 1;
   }