Only use PUT for app config not POST and PUT

Author: brtrvn

resources/saas-boost-public-api.yaml

@@ -64,9 +64,6 @@ Parameters:
   SettingsServiceGetAppConfig:
     Description: Settings Service get application configuration Lambda ARN
     Type: String
-  SettingsServiceSetAppConfig:
-    Description: Settings Service set application configuration Lambda ARN
-    Type: String
   SettingsServiceUpdateAppConfig:
     Description: Settings Service update application configuration Lambda ARN
     Type: String
@@ -815,33 +812,6 @@ Resources:
       Action: lambda:InvokeFunction
       FunctionName: !Ref SettingsServiceGetAppConfig
       SourceArn: !Sub arn:aws:execute-api:${AWS::Region}:${AWS::AccountId}:${PublicApi}/*/GET/settings/config
-  SettingsServiceSetAppConfigMethod:
-    Type: AWS::ApiGateway::Method
-    Properties:
-      RestApiId: !Ref PublicApi
-      ResourceId: !Ref SettingsServiceConfigResource
-      HttpMethod: POST
-      AuthorizationType: COGNITO_USER_POOLS
-      AuthorizerId: !Ref CognitoAuthorizer
-      AuthorizationScopes:
-        - aws.cognito.signin.user.admin
-      Integration:
-        Type: AWS_PROXY
-        IntegrationHttpMethod: POST
-        Uri: !Sub arn:aws:apigateway:${AWS::Region}:lambda:path/2015-03-31/functions/${SettingsServiceSetAppConfig}/invocations
-        PassthroughBehavior: WHEN_NO_MATCH
-      MethodResponses:
-        - StatusCode: '200'
-          ResponseModels: {application/json: Empty}
-          ResponseParameters:
-            method.response.header.Access-Control-Allow-Origin: false
-  SettingsServiceSetAppConfigLambdaPermission:
-    Type: AWS::Lambda::Permission
-    Properties:
-      Principal: apigateway.amazonaws.com
-      Action: lambda:InvokeFunction
-      FunctionName: !Ref SettingsServiceSetAppConfig
-      SourceArn: !Sub arn:aws:execute-api:${AWS::Region}:${AWS::AccountId}:${PublicApi}/*/POST/settings/config
   SettingsServiceUpdateAppConfigMethod:
     Type: AWS::ApiGateway::Method
     Properties:
@@ -1702,7 +1672,6 @@ Resources:
       - SettingsServiceOptionsMethod
       - SettingsServiceOptionsResourceCORS
       - SettingsServiceGetAppConfigMethod
-      - SettingsServiceSetAppConfigMethod
       - SettingsServiceUpdateAppConfigMethod
       - SettingsServiceConfigResourceCORS
       - SettingsServiceGetByIdMethod

resources/saas-boost-svc-onboarding.yaml

@@ -308,6 +308,9 @@ Resources:
             Action:
               - lambda:AddPermission
               - lambda:RemovePermission
+              - lambda:InvokeFunction
+              - lambda:GetFunction
+              - lambda:GetFunctionConfiguration
             Resource:
               - !Sub arn:aws:lambda:${AWS::Region}:${AWS::AccountId}:function:*deploy*
               - !Sub arn:aws:lambda:${AWS::Region}:${AWS::AccountId}:function:saas-boost-app-services-macro
@@ -659,8 +662,6 @@ Resources:
             Action:
               - lambda:InvokeFunction
               - lambda:DeleteFunction
-              #- lambda:GetFunction
-              #- lambda:GetFunctionConfiguration
             Resource:
               - !Sub arn:aws:lambda:${AWS::Region}:${AWS::AccountId}:function:sb-${Environment}-rds-bootstrap-tenant-*
   OnboardingServiceStorageProvisionPolicy:

resources/saas-boost-svc-settings.yaml

@@ -312,37 +312,6 @@ Resources:
           Value: !Ref Environment
         - Key: "BoostService"
           Value: "Settings"
-  SettingsServiceSetAppConfigLogs:
-    Type: AWS::Logs::LogGroup
-    Properties:
-      LogGroupName: !Sub /aws/lambda/sb-${Environment}-settings-set-config
-      RetentionInDays: 30
-  SettingsServiceSetAppConfig:
-    Type: AWS::Lambda::Function
-    Properties:
-      FunctionName: !Sub sb-${Environment}-settings-set-config
-      Role: !GetAtt SettingsServiceExecutionRole.Arn
-      Runtime: java11
-      Timeout: 300
-      MemorySize: 512
-      Handler: com.amazon.aws.partners.saasfactory.saasboost.SettingsService::setAppConfig
-      Code:
-        S3Bucket: !Ref SaaSBoostBucket
-        S3Key: !Sub ${LambdaSourceFolder}/SettingsService-lambda.zip
-      Layers:
-        - !Ref SaaSBoostUtilsLayer
-      Environment:
-        Variables:
-          SAAS_BOOST_ENV: !Ref Environment
-          SAAS_BOOST_EVENT_BUS: !Ref SaaSBoostEventBus
-          RESOURCES_BUCKET: !Ref ResourcesBucket
-      Tags:
-        - Key: "Application"
-          Value: "SaaSBoost"
-        - Key: "Environment"
-          Value: !Ref Environment
-        - Key: "BoostService"
-          Value: "Settings"
   SettingsServiceUpdateAppConfigLogs:
     Type: AWS::Logs::LogGroup
     Properties:
@@ -479,7 +448,7 @@ Resources:
       Runtime: java11
       Timeout: 300
       MemorySize: 1024
-      Handler: com.amazon.aws.partners.saasfactory.saasboost.SettingsService::configOptions
+      Handler: com.amazon.aws.partners.saasfactory.saasboost.SettingsService::options
       Code:
         S3Bucket: !Ref SaaSBoostBucket
         S3Key: !Sub ${LambdaSourceFolder}/SettingsService-lambda.zip
@@ -575,9 +544,6 @@ Outputs:
   SettingsServiceGetAppConfigArn:
     Description: Settings Service get application configuration Lambda ARN
     Value: !GetAtt SettingsServiceGetAppConfig.Arn
-  SettingsServiceSetAppConfigArn:
-    Description: Settings Service set application configuration Lambda ARN
-    Value: !GetAtt SettingsServiceSetAppConfig.Arn
   SettingsServiceUpdateAppConfigArn:
     Description: Settings Service update application configuration Lambda ARN
     Value: !GetAtt SettingsServiceUpdateAppConfig.Arn

resources/saas-boost.yaml

@@ -765,7 +765,6 @@ Resources:
         SettingsServiceById: !GetAtt settings.Outputs.SettingsServiceByIdArn
         SettingsServiceOptions: !GetAtt settings.Outputs.SettingsServiceOptionsArn
         SettingsServiceGetAppConfig: !GetAtt settings.Outputs.SettingsServiceGetAppConfigArn
-        SettingsServiceSetAppConfig: !GetAtt settings.Outputs.SettingsServiceSetAppConfigArn
         SettingsServiceUpdateAppConfig: !GetAtt settings.Outputs.SettingsServiceUpdateAppConfigArn
         TenantServiceGetAll: !GetAtt tenant.Outputs.TenantServiceGetAllArn
         TenantServiceById: !GetAtt tenant.Outputs.TenantServiceByIdArn