Remove Markdown view @State property (gonzalezreal#197)

* Remove state property from Markdown view

* Adopt task(id:priority:_:) in the default image view

Author: gonzalezreal

Sources/MarkdownUI/Extensions/DefaultImageProvider.swift

@@ -12,7 +12,6 @@ public struct DefaultImageProvider: ImageProvider {
 
   public func makeImage(url: URL?) -> some View {
     DefaultImageView(url: url, urlSession: self.urlSession)
-      .id(url)
   }
 }
 

Sources/MarkdownUI/Extensions/DefaultImageView/DefaultImageView.swift

@@ -11,7 +11,7 @@ struct DefaultImageView: View {
     case .notRequested, .loading, .failure:
       Color.clear
         .frame(width: 0, height: 0)
-        .task {
+        .task(id: self.url) {
           await self.viewModel.task(url: self.url, urlSession: self.urlSession)
         }
     case .success(let image, let size):

Sources/MarkdownUI/Views/Markdown.swift

@@ -189,31 +189,22 @@ import SwiftUI
 /// )
 /// ```
 public struct Markdown: View {
-  private enum Storage: Equatable {
-    case text(String)
-    case markdownContent(MarkdownContent)
-
-    var markdownContent: MarkdownContent {
-      switch self {
-      case .text(let markdown):
-        return MarkdownContent(markdown)
-      case .markdownContent(let markdownContent):
-        return markdownContent
-      }
-    }
-  }
-
   @Environment(\.colorScheme) private var colorScheme
   @Environment(\.theme.text) private var text
 
-  @State private var blocks: [Block] = []
-
-  private let storage: Storage
+  private let content: MarkdownContent
   private let baseURL: URL?
   private let imageBaseURL: URL?
 
-  private init(storage: Storage, baseURL: URL?, imageBaseURL: URL?) {
-    self.storage = storage
+  /// Creates a Markdown view from a Markdown content value.
+  /// - Parameters:
+  ///   - content: The Markdown content value.
+  ///   - baseURL: The base URL to use when resolving Markdown URLs. If this value is `nil`, the initializer will consider all
+  ///              URLs absolute. The default is `nil`.
+  ///   - imageBaseURL: The base URL to use when resolving Markdown image URLs. If this value is `nil`, the initializer will
+  ///                   determine image URLs using the `baseURL` parameter. The default is `nil`.
+  public init(_ content: MarkdownContent, baseURL: URL? = nil, imageBaseURL: URL? = nil) {
+    self.content = content
     self.baseURL = baseURL
     self.imageBaseURL = imageBaseURL ?? baseURL
   }
@@ -226,18 +217,13 @@ public struct Markdown: View {
         .modifier(ScaledFontSizeModifier(attributes.fontProperties?.size))
     }
     .textStyle(self.text)
-    .onAppear {
-      // Delay Markdown parsing until the view appears for the first time
-      if self.blocks.isEmpty {
-        self.blocks = self.storage.markdownContent.colorScheme(self.colorScheme).blocks
-      }
-    }
-    .onChange(of: self.storage) { storage in
-      self.blocks = storage.markdownContent.blocks
-    }
     .environment(\.baseURL, self.baseURL)
     .environment(\.imageBaseURL, self.imageBaseURL)
   }
+
+  private var blocks: [Block] {
+    self.content.colorScheme(self.colorScheme).blocks
+  }
 }
 
 extension Markdown {
@@ -249,18 +235,7 @@ extension Markdown {
   ///   - imageBaseURL: The base URL to use when resolving Markdown image URLs. If this value is `nil`, the initializer will
   ///                   determine image URLs using the `baseURL` parameter. The default is `nil`.
   public init(_ markdown: String, baseURL: URL? = nil, imageBaseURL: URL? = nil) {
-    self.init(storage: .text(markdown), baseURL: baseURL, imageBaseURL: imageBaseURL)
-  }
-
-  /// Creates a Markdown view from a Markdown content value.
-  /// - Parameters:
-  ///   - content: The Markdown content value.
-  ///   - baseURL: The base URL to use when resolving Markdown URLs. If this value is `nil`, the initializer will consider all
-  ///              URLs absolute. The default is `nil`.
-  ///   - imageBaseURL: The base URL to use when resolving Markdown image URLs. If this value is `nil`, the initializer will
-  ///                   determine image URLs using the `baseURL` parameter. The default is `nil`.
-  public init(_ content: MarkdownContent, baseURL: URL? = nil, imageBaseURL: URL? = nil) {
-    self.init(storage: .markdownContent(content), baseURL: baseURL, imageBaseURL: imageBaseURL)
+    self.init(MarkdownContent(markdown), baseURL: baseURL, imageBaseURL: imageBaseURL)
   }
 
   /// Creates a Markdown view composed of any number of blocks.