Skip to content

Commit ce58c25

Browse files
committed
rm another check
1 parent 3a052a0 commit ce58c25

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

data_diff/diff_tables.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
from data_diff.thread_utils import ThreadedYielder
1717
from data_diff.table_segment import TableSegment, create_mesh_from_points
1818
from data_diff.tracking import create_end_event_json, create_start_event_json, send_event_json, is_tracking_enabled
19-
from data_diff.abcs.database_types import IKey
19+
from data_diff.abcs.database_types import IKey, Text, String_UUID, Binary_UUID
2020

2121
logger = getLogger(__name__)
2222

@@ -280,6 +280,8 @@ def _bisect_and_diff_tables(self, table1: TableSegment, table2: TableSegment, in
280280
raise NotImplementedError(f"Cannot use a column of type {kt} as a key")
281281

282282
for kt1, kt2 in safezip(key_types1, key_types2):
283+
if isinstance(kt1, String_UUID) and isinstance(kt2, (Text, Binary_UUID)):
284+
continue
283285
if kt1.python_type is not kt2.python_type:
284286
raise TypeError(f"Incompatible key types: {kt1} and {kt2}")
285287

0 commit comments

Comments
 (0)