Skip to content

Commit 5b9fed7

Browse files
Minor changes for ATC paper submission
1 parent ca97ade commit 5b9fed7

File tree

2 files changed

+15
-7
lines changed

2 files changed

+15
-7
lines changed

homa_outgoing.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -519,11 +519,11 @@ void __homa_xmit_data(struct sk_buff *skb, struct homa_rpc *rpc, int priority)
519519
skb->ip_summed = CHECKSUM_PARTIAL;
520520
skb->csum_start = skb_transport_header(skb) - skb->head;
521521
skb->csum_offset = offsetof(struct common_header, checksum);
522-
// tt_record4("calling ip_queue_xmit: skb->len %d, gso_segs %d,"
523-
// "gso_size %d, gso_type %d",
524-
// skb->len, skb_shinfo(skb)->gso_segs,
525-
// skb_shinfo(skb)->gso_size,
526-
// skb_shinfo(skb)->gso_type);
522+
tt_record4("calling ip_queue_xmit: skb->len %d, gso_segs %d,"
523+
"gso_size %d, gso_type %d",
524+
skb->len, skb_shinfo(skb)->gso_segs,
525+
skb_shinfo(skb)->gso_size,
526+
skb_shinfo(skb)->gso_type);
527527

528528
err = ip_queue_xmit((struct sock *) rpc->hsk, skb, &rpc->peer->flow);
529529
// tt_record4("Finished queueing packet: rpc id %llu, offset %d, len %d, "

notes.txt

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,29 @@ Notes for Homa implementation in Linux:
22
---------------------------------------
33

44
* Performance-related tasks:
5+
* Analyze 40-us W4 short message latency by writing a time-trace
6+
analyzer that tracks NIC queue length.
57
* Perhaps limit the number of polling threads per socket, to solve
68
the problems with having lots of receiver threads?
79
* Move some reaping to the pacer? It has time to spare
810
* Figure out why TCP W2 P99 gets worse with higher --client-max
911
* See if turning off c-states allows shorter polling intervals?
10-
* Are Meltdown mitigations really disabled?
1112
* Consider a permanent reduction in rtt_bytes.
1213
* Consider reducing throttle_min_bytes to see if it helps region 1
1314
in the CDF?
1415
* Modify cp_node's TCP to use multiple connections per client-server pair
1516
* Why is TCP beating Homa on cp_server_ports? Perhaps TCP servers are getting
1617
>1 request per kernel call?
17-
* Try measuring performance without polling in Homa?
1818

1919
* Things to do:
20+
* Eliminate hot spots involving NAPI:
21+
* Arrange for incoming bursts to be divided into batches where
22+
alternate batches do their NAPI on 2 different cores.
23+
* To do this, use TCP for Homa!
24+
* Send Homa packets using TCP, and use different ports to force
25+
different NAPI cores
26+
* Interpose on the TCP packet reception hooks, and redirect
27+
real TCP packets back to TCP.
2028
* Implement at-most-once semantics:
2129
* Don't delete server RPCs until acked by client.
2230
* On client, keep small set of completed RPCs in homa_peer

0 commit comments

Comments
 (0)