Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] icon*.development.png #163

Closed
3 tasks done
gitpash opened this issue Aug 31, 2022 · 3 comments · Fixed by #172
Closed
3 tasks done

[RFC] icon*.development.png #163

gitpash opened this issue Aug 31, 2022 · 3 comments · Fixed by #172
Labels
enhancement New feature or request

Comments

@gitpash
Copy link
Contributor

gitpash commented Aug 31, 2022

How do you envision this feature/change to look/work like?

Currently I'm having this issue: need to have 2 version of same extension for stg|prod, mostly I can be done with .env feature, but some assets are hard to do this way. In case if your extension need to have 2 different icons512.png for stg|prod - it is quite hard to achieve. After discussing it a bit in Discord with @louisgv I may suggest adding icon512.development.png capability into generateIcons function.

What is the purpose of this change/feature? Why?

It should be a very straightforward feature to implement, but might be very helpful for publishing

(OPTIONAL) Example implementations

No response

(OPTIONAL) Contact Details

No response

Verify canary release

  • I verified that the issue exists in plasmo canary release

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@gitpash gitpash added the enhancement New feature or request label Aug 31, 2022
@louisgv louisgv changed the title [RFC]: Env for assets resolving [RFC]: icon*.development.png Aug 31, 2022
@louisgv louisgv changed the title [RFC]: icon*.development.png [RFC] icon*.development.png Aug 31, 2022
@ColdSauce
Copy link
Contributor

@gitpash are you interested in contributing a pull request to make this change?

@gitpash
Copy link
Contributor Author

gitpash commented Sep 2, 2022

Yes, I can try 😄

@ColdSauce
Copy link
Contributor

Awesome. Reach out on Discord or here if you're running into difficulties and we can help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants