-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(room_at_capacity_mailer): [PPT-1721|PPT-1852] notify when people_count equals or exceeds capacity #540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will send an email every 20 seconds while the room is at capacity
We probably want to do 2 things:
- track where rooms are at or over capacity (system_id => over_capactity_detected_count)
increment the count every poll - only send an email when the over_capactity_detected_count == 2 (i.e. 5min polling means email sent when over capacity for 10min)
- if a room drops below capacity then delete the system_id from the hash or set to 0
We might also want to ensure only one email is sent per meeting?
but i think the above should work well enough
There is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.