Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Inventory Feature #5

Open
MrButterfl7 opened this issue Dec 31, 2020 · 11 comments
Open

Copy Inventory Feature #5

MrButterfl7 opened this issue Dec 31, 2020 · 11 comments
Labels
enhancement New feature or request

Comments

@MrButterfl7
Copy link

As I mentioned a discord a Copy Inventory similar to the Copy Skin function would be amazing.
Thanks for your work on this.

@PixelRick PixelRick added the enhancement New feature or request label Jan 1, 2021
@PixelRick
Copy link
Owner

PixelRick commented Jan 7, 2021

This is coming.. I will first try to copy multiple full nodes at once to see if it works, otherwise I may have to filter Item stats from Entity stats in the Stats nodes.

@gabrielfsousa
Copy link

i would luv to see this, it will be a nice game+

@TomatoRedi
Copy link

First I would like to congratulate
Second, I would like to support this idea of ​​a "Copy" button, on the side of the item or on the side of the bag,

It will make it much easier to multiply the mods of weapons and equipment or just multiply a single item

I'm Brazilian, I created this account just to thank :)

@PixelRick
Copy link
Owner

This isn't easy because a hash must be generated for each new modable item, and I didn't find the hashing algorithm yet.
I am currently coding something to dump all icons and friendly item descriptions and it involves reversing item related structures. I may find this hashing algorithm along the way.

@hondogitsune
Copy link

Can this be done now with the release of these?
https://www.cyberpunk.net/en/modding-support
Metadata
ArchiveDump
TweakDump
TweakDB IDs

hashing algorithm

they mentioned CRC32B:
https://fearlessrevolution.com/viewtopic.php?p=170348#p170348
https://md5calc.com/hash/crc32b

No idea if this helps, wasn't worth creating a new issue over dropping a few links.
grafik
but this should be possible now

@PixelRick
Copy link
Owner

Actually what they released is their own WIP tools for us. And we already had developed the same.
The only new thing as you say is that they provided us a TweakDBIDs list.
But unfortunately it is still missing 65 ids, it is not much over 12k ids so i will probably remove this warning and make the raw editing optional.
I have been busy on developing a proof of concept for a security vulnerability i discovered with the save files (and i have a real job too), that explains why i didn't add new stuff in here for a while. But it's gonna change next week ;)

@hondogitsune
Copy link

hondogitsune commented Jan 31, 2021

But unfortunately it is still missing 65 ids

This might be absolutely intentional:
https://www.pcgamer.com/cdpr-shuts-down-cyberpunk-mod-that-let-players-have-sex-with-keanu-reeves/

Whilst I don't know what IDs are omitted from us, they simply don't want us to use them? I have no idea ¯\__(ツ_)_/¯

and i have a real job too

Hey I can relate, having a job is BOTH the solution to and the cause of many problems. But what we don't do for some money.
Take your time and don't burn out!

@ZedzDed9792
Copy link

is this still impossible to implement?

@PixelRick
Copy link
Owner

I'll have to take a look at the problem again once I have the core features working with cp1.5.
The inventory is linked to other data entries. That's a first problem to tackle.

@hondogitsune
Copy link

grafik

Could you also implement simple character preset importing and exporting? I'm not asking for editing, just so you can share characters with other people. CyberCAT seems to be deprecated abandonware. Copying to clipboard or tool internal storage hinders effective sharing on modding sites.

I'll have utmost respect though if it is not high on your to-do-list due to real life being important ;)

@PixelRick
Copy link
Owner

@vulpes9
Can you please open a new issue for this ? (Also if you can tell a bit more about it: Has CyberCAT got this feature ? What data a "character preset" should include ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants