radio: config: 1.1-wrapper: Enable mobile data at last

me-cafebabe · me-cafebabe · commit 65cabbc3b023 · 2024-06-02T19:53:51.000+08:00
* This fixes mobile data for a user who have Redmi 3S (running latest
  global firmware) with single SIM on SIM1 slot
  (it doesn't happen for me and the others, though)

* Logically, Enabling stuff after disabling finishes should be safer

Change-Id: I1bc84f8d4a4a449cb478143b01adf9cc2a4db6de
diff --git a/radio/config/1.1-wrapper/RadioConfig.cpp b/radio/config/1.1-wrapper/RadioConfig.cpp
@@ -144,8 +144,10 @@ Return<void> RadioConfig::setPreferredDataModem(int32_t serial, uint8_t modemId)
         radioError = RadioError::INVALID_ARGUMENTS;
     } else {
         for (uint8_t i = 0; i < radios.size(); i++) {
-            radios[i]->setDataAllowed(-1, i == modemId);
+            if (i != modemId) radios[i]->setDataAllowed(-1, false);
         }
+
+        radios[modemId]->setDataAllowed(-1, true);
     }
 
     auto radioConfigResponseV1_1 = mRadioConfigResponseV1_1;

Original file line number	Diff line number	Diff line change
`@@ -144,8 +144,10 @@ Return<void> RadioConfig::setPreferredDataModem(int32_t serial, uint8_t modemId)`
`144`	`144`	`radioError = RadioError::INVALID_ARGUMENTS;`
`145`	`145`	`} else {`
`146`	`146`	`for (uint8_t i = 0; i < radios.size(); i++) {`
`147`		`- radios[i]->setDataAllowed(-1, i == modemId);`
	`147`	`+ if (i != modemId) radios[i]->setDataAllowed(-1, false);`
`148`	`148`	`}`
	`149`	`+`
	`150`	`+ radios[modemId]->setDataAllowed(-1, true);`
`149`	`151`	`}`
`150`	`152`
`151`	`153`	`auto radioConfigResponseV1_1 = mRadioConfigResponseV1_1;`