Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too long compilation time #45

Closed
simnalamburt opened this issue Sep 4, 2016 · 6 comments
Closed

Too long compilation time #45

simnalamburt opened this issue Sep 4, 2016 · 6 comments
Assignees

Comments

@simnalamburt
Copy link
Member

Using all default features of image crate leads this crate to bloated compilation time which is undesirable. We should opt-in those featuers. Below codes are the brief example of how to do it.

[features]
## create a feature in your app
default = ["gif_codec", "jpeg", "ico", "png_codec", "ppm", "tga", "tiff", "webp", "bmp", "hdr"]

gif_codec = ["image/gif_codec"]
ico = ["image/ico"]
jpeg = ["image/jpeg"]
png_codec = ["image/png_codec"]
ppm = ["image/ppm"]
tga = ["image/tga"]
tiff = ["image/tiff"]
webp = ["image/webp"]
bmp = ["image/bmp"]
hdr = ["image/hdr"]

[dependencies]
image = { version = "0.10.0", default-features = false }
References
@simnalamburt simnalamburt self-assigned this Sep 4, 2016
@bvssvni
Copy link
Member

bvssvni commented Sep 4, 2016

Isn't there a way to disable default cargo features and then enable them by adding a dependency to the library in the top project?

@simnalamburt
Copy link
Member Author

@bvssvni It's possible but I intensionally choosed not to since it's unnecessary backward compatibility breakage.

@bvssvni
Copy link
Member

bvssvni commented Sep 5, 2016

Don't worry about breaking stuff! We'll just bump the version and existing code will continue to work with the old version.

@simnalamburt
Copy link
Member Author

OK then. If we enhance documentations and examples, maybe it can be a good chance for texture_packer to be 1.0.0

I'll propose a PR soon.

@bvssvni
Copy link
Member

bvssvni commented Sep 5, 2016

We don't need 1.0.0 yet, 0.9.0 will work just fine because it is the first non-zero number that is interpreted as a breaking change by Cargo. However, it would be nice to do as you say.

@simnalamburt
Copy link
Member Author

Oops, sorry. That was a mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants