Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Based on Integration Blueprint #171

Merged
merged 14 commits into from
Jan 11, 2024
Merged

Updates Based on Integration Blueprint #171

merged 14 commits into from
Jan 11, 2024

Conversation

cloneofghosts
Copy link
Collaborator

@cloneofghosts cloneofghosts commented Jan 6, 2024

I've noticed that there's been updates to the integration blueprint since the creation of this repo and this PR adds in the items that are not contained in this repo.

Ruff has been added to the blueprint as a workflow which is a Python linter/code formatter and after getting it to run on my repo it showed 359 errors.

@cloneofghosts cloneofghosts marked this pull request as draft January 7, 2024 01:36
@cloneofghosts cloneofghosts changed the base branch from master to blueprint-update January 7, 2024 03:24
@cloneofghosts
Copy link
Collaborator Author

cloneofghosts commented Jan 7, 2024

I created a separate branch for these updates so the fixes can be done there without impacting the main branch (could also solve #169 at the same time as well).

I also added in the ruff formatter as well to the action which will automatically format and it will commit the changes automatically as well though since the lint action fails it doesn't commit anything at the moment. Can fix that by using the --exit-zero argument so the auto commit step gets reached. I also tested the --fix argument on a separate branch if you want to see how it works.

EDIT: Also noticed that there's still a reference to the old API signup page and it should be updated to use APIable:

errors["base"] = "Invalid API Key, Ensure that the subscribe button is clicked for this endpoint: https://pirateweather.net/apis/hv9nrw1tjg/Beta"

@cloneofghosts cloneofghosts marked this pull request as ready for review January 7, 2024 18:39
@cloneofghosts
Copy link
Collaborator Author

cloneofghosts commented Jan 8, 2024

Cleaned up more of the lint errors and now there's only 4 things left which I might leave for you to fix. I also fixed the deprecated constants issue in sensor.py as well.

I haven't tested to see if everything is still running without issues (I don't have a dev machine to test and I don't have Visual Studio code installed either) but it validating is a good sign?

EDIT: I tried to update a personal branch with the latest changes and it wouldn't let me fix the merge commits on GitHub without updating master for some reason. Anyway I reverted the changes here. I also fixed the last remaining errors but still unsure that nothing will totally break.

@cloneofghosts cloneofghosts merged commit 3cb7ed9 into Pirate-Weather:blueprint-update Jan 11, 2024
3 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants