-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Removing SDK package and updating README #19151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughRemoved the SDK package contents: package manifest, build/test configs, TypeScript configs, browser/server entrypoints and clients, shared types/exports, examples, tests, scripts, CI workflows, ignore rules; added a README notice pointing to the pipedream-sdk-typescript repository. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45–90 minutes Areas to focus review on:
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
packages/sdk/README.md(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
Repo: PipedreamHQ/pipedream PR: 14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
packages/sdk/README.md
🪛 GitHub Actions: Lint SDK Markdown Files
packages/sdk/README.md
[error] 1-1: markdownlint: MD013/line-length Line length [Expected: 80; Actual: 199]
🪛 GitHub Check: test
packages/sdk/README.md
[failure] 1-1: First line in a file should be a top-level heading
packages/sdk/README.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "Note: this package is now ..."] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md041.md
[failure] 1-1: Line length
packages/sdk/README.md:1:81 MD013/line-length Line length [Expected: 80; Actual: 199] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md013.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Lint Code Base
- GitHub Check: pnpm publish
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
packages/sdk/README.md(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
Repo: PipedreamHQ/pipedream PR: 14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
packages/sdk/README.md
🪛 GitHub Actions: Lint SDK Markdown Files
packages/sdk/README.md
[error] 7-7: MD024/no-duplicate-heading: Multiple headings with the same content. Context: "@pipedream/sdk"
🪛 GitHub Check: test
packages/sdk/README.md
[failure] 7-7: Multiple top-level headings in the same document
packages/sdk/README.md:7 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: "@pipedream/sdk"] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md025.md
[failure] 7-7: Multiple headings with the same content
packages/sdk/README.md:7 MD024/no-duplicate-heading Multiple headings with the same content [Context: "@pipedream/sdk"] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md024.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
packages/sdk/README.md(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
Repo: PipedreamHQ/pipedream PR: 14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
packages/sdk/README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Lint Code Base
🔇 Additional comments (1)
packages/sdk/README.md (1)
1-7: Structure and previous feedback correctly addressed.The README now correctly places the H1 heading first (line 1), includes the blockquote note (lines 3–6) after a blank line, and contains no duplicate headings. This structure satisfies the MD041 linting requirement flagged in the previous review.
| > **Note:** This package is now maintained in the | ||
| > [pipedream-sdk-typescript](https://github.com/PipedreamHQ/pipedream-sdk-typescript) | ||
| > repository. Visit that to view the most up-to-date code of the SDK. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Minor: Consider clarifying the pronoun in the note.
Line 5 reads "Visit that to view the most up-to-date code…", where "that" is a forward reference to the repository mentioned on line 4. This works, but could be marginally clearer as "Visit there to view" or "Visit that repository to view" for improved readability.
This is optional; the current wording is acceptable.
🤖 Prompt for AI Agents
packages/sdk/README.md lines 3-6: the pronoun "that" in "Visit that to view the
most up-to-date code…" is a bit ambiguous; change it to a clearer phrase such as
"there" or "that repository" so the sentence reads e.g. "Visit that repository
to view the most up-to-date code of the SDK." Ensure only the wording is
adjusted and punctuation remains correct.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.