Remove bad check during buffer write. (proxy-wasm#27)

jplevyak · web-flow · commit f25f824b2509 · 2020-06-25T08:51:23.000-07:00
Signed-off-by: John Plevyak &lt;jplevyak@gmail.com&gt;
diff --git a/src/exports.cc b/src/exports.cc
@@ -514,10 +514,6 @@ Word set_buffer_bytes(void *raw_context, Word type, Word start, Word length, Wor
   if (!data) {
     return WasmResult::InvalidMemoryAccess;
   }
-  // check for overflow.
-  if (buffer->size() < start + length || start > start + length) {
-    return WasmResult::BadArgument;
-  }
   return buffer->copyFrom(start, length, data.value());
 }
 

Original file line number	Diff line number	Diff line change
`@@ -514,10 +514,6 @@ Word set_buffer_bytes(void *raw_context, Word type, Word start, Word length, Wor`
`514`	`514`	`if (!data) {`
`515`	`515`	`return WasmResult::InvalidMemoryAccess;`
`516`	`516`	`}`
`517`		`- // check for overflow.`
`518`		`- if (buffer->size() < start + length \|\| start > start + length) {`
`519`		`- return WasmResult::BadArgument;`
`520`		`- }`
`521`	`517`	`return buffer->copyFrom(start, length, data.value());`
`522`	`518`	`}`
`523`	`519`