From 43bcbeaa981812634bd3f9aafdeb3ac2ef2a325f Mon Sep 17 00:00:00 2001 From: Rick Ossendrijver Date: Wed, 21 Sep 2022 08:23:09 +0200 Subject: [PATCH] Update `XXX` comments to reference google/error-prone#2706 (#249) --- .../refastertemplates/ImmutableListMultimapTemplates.java | 4 ++-- .../refastertemplates/ImmutableListTemplates.java | 4 ++-- .../refastertemplates/ImmutableMapTemplates.java | 4 ++-- .../refastertemplates/ImmutableMultisetTemplates.java | 4 ++-- .../refastertemplates/ImmutableSetMultimapTemplates.java | 4 ++-- .../refastertemplates/ImmutableSetTemplates.java | 4 ++-- .../refastertemplates/ImmutableSortedMapTemplates.java | 8 ++++---- 7 files changed, 16 insertions(+), 16 deletions(-) diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListMultimapTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListMultimapTemplates.java index 2ef8696f70..0174bae0b1 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListMultimapTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListMultimapTemplates.java @@ -33,8 +33,8 @@ private ImmutableListMultimapTemplates() {} * Prefer {@link ImmutableListMultimap#builder()} over the associated constructor on constructions * that produce a less-specific type. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See + // https://github.com/google/error-prone/pull/2706. static final class ImmutableListMultimapBuilder { @BeforeTemplate ImmutableMultimap.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListTemplates.java index 2b73212db7..711426361b 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListTemplates.java @@ -26,8 +26,8 @@ final class ImmutableListTemplates { private ImmutableListTemplates() {} /** Prefer {@link ImmutableList#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See + // https://github.com/google/error-prone/pull/2706. static final class ImmutableListBuilder { @BeforeTemplate ImmutableList.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMapTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMapTemplates.java index fedbc9bfb7..8429e1b3d5 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMapTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMapTemplates.java @@ -27,8 +27,8 @@ final class ImmutableMapTemplates { private ImmutableMapTemplates() {} /** Prefer {@link ImmutableMap#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See + // https://github.com/google/error-prone/pull/2706. static final class ImmutableMapBuilder { @BeforeTemplate ImmutableMap.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMultisetTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMultisetTemplates.java index 0bfb8ecdbd..d60264965f 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMultisetTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMultisetTemplates.java @@ -19,8 +19,8 @@ final class ImmutableMultisetTemplates { private ImmutableMultisetTemplates() {} /** Prefer {@link ImmutableMultiset#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See + // https://github.com/google/error-prone/pull/2706. static final class ImmutableMultisetBuilder { @BeforeTemplate ImmutableMultiset.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetMultimapTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetMultimapTemplates.java index fa4251e82a..ed991be8ef 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetMultimapTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetMultimapTemplates.java @@ -27,8 +27,8 @@ final class ImmutableSetMultimapTemplates { private ImmutableSetMultimapTemplates() {} /** Prefer {@link ImmutableSetMultimap#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See + // https://github.com/google/error-prone/pull/2706. static final class ImmutableSetMultimapBuilder { @BeforeTemplate ImmutableSetMultimap.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetTemplates.java index 2af6ec74dc..a3ef63e71f 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetTemplates.java @@ -23,8 +23,8 @@ final class ImmutableSetTemplates { private ImmutableSetTemplates() {} /** Prefer {@link ImmutableSet#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See + // https://github.com/google/error-prone/pull/2706. static final class ImmutableSetBuilder { @BeforeTemplate ImmutableSet.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSortedMapTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSortedMapTemplates.java index f112dcb551..e5e265d684 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSortedMapTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSortedMapTemplates.java @@ -35,8 +35,8 @@ ImmutableSortedMap.Builder after(Comparator cmp) { * Prefer {@link ImmutableSortedMap#naturalOrder()} over the alternative that requires explicitly * providing the {@link Comparator}. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See + // https://github.com/google/error-prone/pull/2706. static final class ImmutableSortedMapNaturalOrderBuilder, V> { @BeforeTemplate ImmutableSortedMap.Builder before() { @@ -53,8 +53,8 @@ ImmutableSortedMap.Builder after() { * Prefer {@link ImmutableSortedMap#reverseOrder()} over the alternative that requires explicitly * providing the {@link Comparator}. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See + // https://github.com/google/error-prone/pull/2706. static final class ImmutableSortedMapReverseOrderBuilder, V> { @BeforeTemplate ImmutableSortedMap.Builder before() {