Stop using invalid password authenticator
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieucan
approved these changes
Jun 11, 2024
dlouseiro
deleted the
dlouseiro/stop-using-invalid-password-authenticator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to fix a bug in the authentication behaviour, introduced in this PR.
While the feature referenced above worked successfully for cases when the
authenticator=externalbrowserit was not working in cases where an authentication with user and password was intended, as the valuepasswordis invalid for theauthenticatorparameter ofsnowflake-connector-python.As the authentication with user/password is the default authentication behaviour of the snowflake connector, the implementation was changed for
DatabaseConfiguration.authenticatorto accept eitherexternalbrowseror default to theDEFAULT_AUTHENTICATORfromsnowflake-connector, the latter triggering a successful authentication using user and password