Drop yaml brackets for consistency and readability #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
approved these changes
May 3, 2024
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
|
So after the approval, what's next? 🙂 |
pac48
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in some reviews internally that the brackets were used inconsistently. Turns out they were mostly copy pasted from the great parameter library.
May I suggest dropping the bracket syntax? It's yaml after-all, not json 🙂
As you can already see in the first README example, it was a bit inconsistent, they are not used after
turtlesimbut are used afterbackground.