Skip to content

Commit 1a57dac

Browse files
Add sea-bass suggestions
1 parent bd7c608 commit 1a57dac

File tree

4 files changed

+16
-9
lines changed

4 files changed

+16
-9
lines changed

example_external/README.md

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
# Example:
1+
# Using parameters defined in another package
2+
3+
This package is a minimal example demonstrating how the parameters defined in `generate_parameter_library/example`
4+
can be used in a different package (i.e. the current one : `generate_parameter_library/example_external`).
5+
6+
In particular, check the `CMakeLists.txt` file and the `#include` instructions in the source files.
27

38
## Build the node
49

@@ -93,7 +98,8 @@ You should see:
9398
use_sim_time
9499
```
95100

96-
All parameter are automatically declared and callbacks are setup by default. You can set a parameter by typing:
101+
All parameters are automatically declared and callbacks are setup by default.
102+
You can set a parameter by typing:
97103

98104
`ros2 param set /admittance_controller control.frame.id new_frame`
99105

@@ -103,7 +109,8 @@ You should see:
103109

104110
Congratulations, you updated the parameter!
105111

106-
If you try to set a parameter that is read only, you will get an error. Running the following
112+
If you try to set a parameter that is read only, you will get an error.
113+
Running the following
107114

108115
`ros2 param set /admittance_controller command_interfaces ["velocity"]`
109116

example_external/include/generate_parameter_library_example_external/minimal_publisher_external.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2022 PickNik Inc.
1+
// Copyright 2025 Forssea Robotics
22
//
33
// Redistribution and use in source and binary forms, with or without
44
// modification, are permitted provided that the following conditions are met:
@@ -10,7 +10,7 @@
1010
// notice, this list of conditions and the following disclaimer in the
1111
// documentation and/or other materials provided with the distribution.
1212
//
13-
// * Neither the name of the PickNik Inc. nor the names of its
13+
// * Neither the name of Forssea Robotics nor the names of its
1414
// contributors may be used to endorse or promote products derived from
1515
// this software without specific prior written permission.
1616
//

example_external/src/minimal_publisher_external.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2022 PickNik Inc.
1+
// Copyright 2025 Forssea Robotics
22
//
33
// Redistribution and use in source and binary forms, with or without
44
// modification, are permitted provided that the following conditions are met:
@@ -10,7 +10,7 @@
1010
// notice, this list of conditions and the following disclaimer in the
1111
// documentation and/or other materials provided with the distribution.
1212
//
13-
// * Neither the name of the PickNik Inc. nor the names of its
13+
// * Neither the name of Forssea Robotics nor the names of its
1414
// contributors may be used to endorse or promote products derived from
1515
// this software without specific prior written permission.
1616
//

parameter_traits/include/parameter_traits/parameter_traits.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ template <typename... Args>
4343
[[deprecated(
4444
"When returning tl::expected<void, std::string> you can call fmt::format "
4545
"directly.")]] auto
46-
ERROR(const std::string& format, Args... args)
47-
-> tl::expected<void, std::string> {
46+
ERROR(const std::string& format,
47+
Args... args) -> tl::expected<void, std::string> {
4848
return tl::make_unexpected(fmt::format(format, args...));
4949
}
5050

0 commit comments

Comments
 (0)