Fix flying strings drawing through Fog of War#2229
Draft
juliuss007 wants to merge 1 commit into
Draft
Conversation
TaranDahl
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a narrow part of #28.
This keeps Phobos flying text and money display strings from drawing while their map location is covered by fog or shroud. The existing helper already checks both conditions, but the draw loop did not use it, and money strings only checked shroud when they were created.
What changed:
AddMoneyStringinterface is unchangedVerification:
git diff --checkpassedAddMoneyStringcall sites; the signature is unchangedUpdateAllgatesDrawTextwithDrawAllowedand keeps expiry cleanupI could not run the full Phobos build in this workspace because it is macOS and the project requires Visual Studio/MSBuild with the Windows SDK.
clang++ -fsyntax-onlystops at the missingwindows.h, andcmd.exe /c scripts\\build_debug.batis not available here.This is intentionally not a full Fog of War rewrite; it only addresses the flying text / money display leakage path.