Skip to content

Fixed voxel projectile and animation lighting issues#2228

Open
TaranDahl wants to merge 3 commits into
Phobos-developers:developfrom
TaranDahl:NonTechnoVoxelTintFix
Open

Fixed voxel projectile and animation lighting issues#2228
TaranDahl wants to merge 3 commits into
Phobos-developers:developfrom
TaranDahl:NonTechnoVoxelTintFix

Conversation

@TaranDahl
Copy link
Copy Markdown
Contributor

In vanilla, they are darker than voxel technos.

@TaranDahl TaranDahl added ❓Vanilla bug Vanilla game bugs that are requested to be fixed Needs testing ⚙️T1 T1 maintainer review is sufficient Bugfix This is a bugfix that does not need documentation beyond mention in changelog labels May 26, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 26, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Copy link
Copy Markdown
Contributor

@NetsuNegi NetsuNegi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Metadorius
Copy link
Copy Markdown
Member

can we get a visual?

@TaranDahl
Copy link
Copy Markdown
Contributor Author

Vanilla:
VoxelProjFix-Vanilla
Fixed:
VoxelProjFix-Fixed

@TaranDahl TaranDahl added Tested Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. and removed Needs testing labels May 27, 2026
@DeathFishAtEase
Copy link
Copy Markdown
Collaborator

Is the performance impact caused by this fix such that it necessitates adding a switch?

@TaranDahl
Copy link
Copy Markdown
Contributor Author

Is the performance impact caused by this fix such that it necessitates adding a switch?

I suppose bullets and voxelanims(debris) stay for a very short time on the map, thus they make a minor impact on performance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This is a bugfix that does not need documentation beyond mention in changelog ⚙️T1 T1 maintainer review is sufficient Tested ❓Vanilla bug Vanilla game bugs that are requested to be fixed Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants