-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to Android Studio 3.1.2 #3975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few lines can be removed, other than that this looks right.
@@ -4,6 +4,7 @@ | |||
import android.graphics.Color; | |||
import android.graphics.Typeface; | |||
import android.os.Bundle; | |||
import android.util.Log; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason for this line
xAxis.setDrawAxisLine(false); | ||
xAxis.setDrawGridLines(true); | ||
xAxis.setTextColor(Color.rgb(255, 192, 56)); | ||
// xAxis.setTextColor(Color.rgb(255, 192, 56)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be deleted
@@ -36,6 +37,8 @@ protected void onCreate(@Nullable Bundle savedInstanceState) { | |||
|
|||
mTfRegular = Typeface.createFromAsset(getAssets(), "OpenSans-Regular.ttf"); | |||
mTfLight = Typeface.createFromAsset(getAssets(), "OpenSans-Light.ttf"); | |||
|
|||
Log.d("OpenActivity", this.getClass().getName()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there is no reason for this change either (and its import).
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest version of Gradle is 4.7
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gradle build tools 3.1.2 doesn't work with gradle > 4.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the doc, it should be compatible with Gradle 4.4+. If it doesn't, I guess there is a bug in either the plugin or Gradle.
Plugin version | Required Gradle version |
---|---|
3.1.0+ | 4.4+ |
54e1cc7
to
d8ea67a
Compare
It does seem that new gradle versions are available, however since Android Studio is only automatically updating to 4.4, that should be fine for now. I just built this version and it worked, merging. |
gradle build tools 3.1.2 doesn't work with gradle > 4.5
First suggestion doesn't work too. |
update to Android Studio 3.1.2
This PR updates to most recent stable Android Studio 3.1.2