Skip to content

Conversation

HomaFarahani
Copy link

No description provided.

@PhasicFlow
Copy link
Owner

  1. the files should be located under tutorials/postprocessPhasicFlow/rotatingDrum folder.
  2. You also have to provide the simulation case setup files, similar to what we have in other tutorials.
  3. The problem definition does not describe the purpose of the simulation. We are aiming to perform post processing.
  4. In addition to configuring postprocessDataDict, you need to make changes to settingsDict. I dont see any trace of this in the readme file.
  5. You also need to provide an image or graph or a combination of these to represent the problem.
  6. Comments in the code is not enough. The descriptions of different parts is not adequate.

Please apply these changes and re-push the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants