Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Polkadot v0.9.43 #1313

Merged
merged 15 commits into from
Jul 3, 2023
Merged

Upgrade to Polkadot v0.9.43 #1313

merged 15 commits into from
Jul 3, 2023

Conversation

@jasl jasl force-pushed the polkadot-v0.9.43 branch 2 times, most recently from 5c28b2a to 343a208 Compare June 29, 2023 12:13
@jasl jasl requested a review from kvinwang June 30, 2023 11:46
@jasl jasl marked this pull request as ready for review June 30, 2023 12:01
@jasl
Copy link
Collaborator Author

jasl commented Jun 30, 2023

@kvinwang please help to check the fail of Build contracts

make[3]: Leaving directory '/home/runner/work/phala-blockchain/phala-blockchain/crates/pink-drivers/system'
Caused by:
make[2]: Leaving directory '/home/runner/work/phala-blockchain/phala-blockchain/crates/pink-drivers'
make[1]: Leaving directory '/home/runner/work/phala-blockchain/phala-blockchain/e2e/res'
    0: Loading of wasm module at '/home/runner/work/phala-blockchain/phala-blockchain/crates/pink-drivers/system/target/ink/wasm32-unknown-unknown/release/system.wasm' failed
    1: Unknown opcode 192
make[3]: *** [../build-contract.mk:8: target/ink/system.contract] Error 1
make[2]: *** [Makefile:17: install-system] Error 2
make[1]: *** [Makefile:9: drivers] Error 2
make: *** [Makefile:10: e2e] Error 2
Error: Process completed with exit code 2.

@kvinwang
Copy link
Collaborator

@kvinwang please help to check the fail of Build contracts

It'a known issue using Rustc 1.70. See #1294
Is it necessary to upgrade rustc?

@jasl
Copy link
Collaborator Author

jasl commented Jun 30, 2023

#1294

OK I‘ll revert the change

@jasl
Copy link
Collaborator Author

jasl commented Jul 1, 2023

All green now, CI won't test Dockerfile, so need test manually

Copy link
Collaborator

@kvinwang kvinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasl jasl merged commit b3512da into master Jul 3, 2023
@jasl jasl deleted the polkadot-v0.9.43 branch July 3, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants