chore: update permify api version v1.3.2 #2050
Conversation
WalkthroughThis pull request updates the API version from "v1.3.1" to "v1.3.2" across documentation files and the internal version constant. It also modifies the Changes
Sequence Diagram(s)sequenceDiagram
participant S as Serve Component
participant B as Balancer Engine
participant T as TLS Creator
S ->> B: Call NewCheckEngineWithBalancer(cfg.NameOverride, ...)
B ->> T: Create TLS credentials using 'no'
T -->> B: Return TLS Credentials
B -->> S: Return Checker Engine
Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 golangci-lint (1.62.2)level=warning msg="[config_reader] The configuration option ✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
internal/engines/balancer/balancer.go (1)
36-36: Consider using a more descriptive parameter name.The parameter name
nois not very descriptive. Consider renaming it to something more meaningful likeserverNameOverrideortlsServerNameto better reflect its purpose as the server name used for TLS credentials.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pkg/pb/base/v1/openapi.pb.gois excluded by!**/*.pb.go
📒 Files selected for processing (6)
docs/api-reference/apidocs.swagger.json(1 hunks)docs/api-reference/openapiv2/apidocs.swagger.json(1 hunks)internal/engines/balancer/balancer.go(2 hunks)internal/info.go(1 hunks)pkg/cmd/serve.go(1 hunks)proto/base/v1/openapi.proto(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- proto/base/v1/openapi.proto
- internal/info.go
- docs/api-reference/apidocs.swagger.json
- docs/api-reference/openapiv2/apidocs.swagger.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Test with Coverage
- GitHub Check: Analyze (go)
🔇 Additional comments (2)
pkg/cmd/serve.go (1)
450-458: Function call updated to match new signature.The code now correctly passes
cfg.NameOverrideas a parameter tobalancer.NewCheckEngineWithBalancer(), which matches the updated function signature in the balancer package. This parameter is used for TLS credential initialization in distributed mode.internal/engines/balancer/balancer.go (1)
51-51: Parameter now used for TLS server name verification.The new parameter is correctly passed to
credentials.NewClientTLSFromFile()as the server name. This allows for proper TLS verification when connecting to servers in distributed mode.
Summary by CodeRabbit