core_surface.t: test/data/icon.bmp is really 4 bits per pixel #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to track down the exact commit in SDL that caused this to start failing, but things are pretty clear after looking at the file that this test uses, i.e.
test/data/icon.bmp
. Here's a dump of the file's headers :According to Wikipedia, the first 14 bytes are the standard "Bitmap file header". Four-byte integer at offset 0x0E is 0x28 which means
BITMAPINFOHEADER
so the number of bits per pixel is stored as a two-byte integer at offset 0x1C, which is indeed 4.