Skip to content

Commit 2fd45f9

Browse files
bookLeont
authored andcommitted
fix string comparisons with $] to use numeric comparison instead
The fix follows Zefram's suggestion from https://www.nntp.perl.org/group/perl.perl5.porters/2012/05/msg186846.html > On older perls, however, $] had a numeric value that was built up using > floating-point arithmetic, such as 5+0.006+0.000002. This would not > necessarily match the conversion of the complete value from string form > [perl #72210]. You can work around that by explicitly stringifying > $] (which produces a correct string) and having *that* numify (to a > correctly-converted floating point value) for comparison. I cultivate > the habit of always stringifying $] to work around this, regardless of > the threshold where the bug was fixed. So I'd write > > use if "$]" >= 5.014, warnings => "non_unicode";
1 parent 8516aba commit 2fd45f9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/coretests.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ SKIP: {
348348

349349
SKIP: {
350350
skip 'Cannot test bare alpha v-strings with Perl < 5.8.1', 2
351-
if $] lt 5.008_001;
351+
if "$]" < 5.008_001;
352352
$version = $CLASS->$method(v1.2.3_4);
353353
$DB::single = 1;
354354
is($version, "v1.2.34", '"$version" eq "v1.2.34"');

0 commit comments

Comments
 (0)