sv.h - Update type comments to reflect implementation realities #20787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demerphq
requested changes
Feb 10, 2023
sv.h
Outdated
| be a rare use case.) C<SVt_PV> can hold C<undef>, a string, or a reference. | ||
| C<SVt_PVIV> is a superset of C<SVt_PV> and C<SVt_IV>. C<SVt_PVNV> is similar. | ||
| C<SVt_PVMG> can hold anything C<SVt_PVNV> can hold, but it can, but does not | ||
| have to, be blessed or magical. |
There was a problem hiding this comment.
The last two sentences read a little bit awkward. Maybe:
C<SVt_PVNV> is similar as it is a superset of C<SVt_PV> and C<SVt_NV>. C<SVt_PVMG> can hold anything that a C<SVt_PVNV> can, but may also be blessed or magical as well.
im not sure that "hold" is the best word for this doc, but its not the worst either. I think id use "represent" or "store" but its a matter of preference I guess.
There was a problem hiding this comment.
They are both the pre-existing text, but I'm happy to make changes.
demerphq
approved these changes
Feb 10, 2023
khwilliamson
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20698