Skip to content

Bump blead to Perl version 7.1.0 #18020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Bump blead to Perl version 7.1.0 #18020

wants to merge 4 commits into from

Conversation

atoomic
Copy link
Member

@atoomic atoomic commented Aug 3, 2020

This pull request bumps the Perl version to 7.1.0 with some incremental changes:

  • Devel-PPPort: update to last upstream version
  • version: use PERL_VERSION compare macros
  • hreads: use PERL_VERSION compare macros
  • Storable: use PERL_COMPARE macros
  • Update Perl version to 7.0.0
  • Update Perl version to 7.1.0

Note that in order to provide backward compatibility with XS distributions, PERL_REVISION, PERL_VERSION and PERL_SUBVERSION are frozen at 5.255.255 (view patchlevel.h)

New semantic versioning macros are introduced as part of this change:
PERL_VERSION_MAJOR, PERL_VERSION_MINOR, PERL_VERSION_PATCH

This is solving XS issues where PERL_VERSION is used without checking PERL_REVISION but also fixing issues from old version of ppport.h which only support the major version being 5.

It's recommended to use the compare functions PERL_VERSION_EQ, PERL_VERSION_LT... instead of a direct access to these macros.

@atoomic atoomic added this to the 7.1.1 milestone Aug 3, 2020
This was referenced Aug 3, 2020
Merged
Merged
Closed
atoomic added a commit that referenced this pull request Aug 3, 2020
@atoomic
Fixup handy.h to use PERL_VERSION macro
d67f622 
handy.h was recently updated in 4a1bbd3 but
this is not using the accurate definitions
of the new semantic versions introduced as part of #18020

They are:
- PERL_VERSION_MAJOR
- PERL_VERSION_MINOR
- PERL_VERSION_PATCH
tonycoz
tonycoz requested changes Aug 3, 2020
View reviewed changes
@atoomic atoomic force-pushed the blead_to_710-PR branch 2 times, most recently from e81ec71 to 334c9a4 Compare August 3, 2020 05:46
@atoomic atoomic requested a review from tonycoz August 3, 2020 05:47
Tux
Tux reviewed Aug 3, 2020
View reviewed changes
Porting/Glossary
In a Perl version number such as 5.6.2, this is the 2.
Values greater than 50 represent potentially unstable
development subversions.
This value is manually set in patchlevel.h

PERL_VERSION (Oldsyms.U):
PERL_VERSION_MINOR (Oldsyms.U):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need a new meta-unit. Oldsyms.U sounds a little confusing now.
Given that, maybe it is a good thing to keep Oldsyms.U which documents the old symbols for a while (with the replaced-by names) to be removed in 7.4.0 or so.

INSTALL
@@ -615,7 +615,7 @@ The directories set up by Configure fall into three broad categories.

=item Directories for the perl distribution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INSTALL will need a note that as of 7.0.0 the prefix will be .../lib/perl instead of .../lib/perl5 (which is likely to break some code that analyses already installed modules)

As a side note, will perl-7.x.x be able to load modules from perl-5.x.x when inc_version_list not equals to none.
If so, do we need a new parameter to Configure to define that location?

Configure
@@ -1901,7 +1901,7 @@ fi
touch posthint.sh

: set package name
package='perl5'
package='perl7'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not yet found time to dig into rebuilding Configure with all these changes, so I have no idea if anything would be impacted at all. I will need to find time first to experiment and time to backport all changes.

@leonerd
Copy link
Contributor

leonerd commented Aug 3, 2020

Are we going to rename the repo at the same time? If the version becomes 7.x, the repo name perl5 won't seem so fitting. Could be good to rename it then.

@atoomic
Copy link
Member Author

atoomic commented Aug 3, 2020

Indeed we can rename the repo once merged. Not sure about the best timing.
Keep in mind that once renamed, GitHub does a pretty good job of redirecting all old urls to the new repo.
We would have to adjust all urls in the current code source to use the new name.

@atoomic atoomic force-pushed the blead_to_710-PR branch 2 times, most recently from 1114834 to 482f4e5 Compare August 3, 2020 21:50
atoomic and others added 2 commits August 4, 2020 14:31
@atoomic
version: use PERL_VERSION compare macros
b1d187d 
Use new core PERL_VERSION compare macros in vxs.inc
When bumping version which this change
we would need to make sure to use the last
version of ppport.h
@atoomic
Remove transitional helpers from handy.h
142676a
atoomic added 2 commits August 4, 2020 14:33
@atoomic
Update Perl version to 7.0.0
2d24c53 
To provide backward compatibility with XS code
PERL_REVISION, PERL_VERSION and PERL_SUBVERSION
are frozen at 5.255.255 - view patchlevel.h

This is introducing new Perl semantic versioning macros:
PERL_VERSION_MAJOR, PERL_VERSION_MINOR, PERL_VERSION_PATCH

It's recommended to use the compare functions
PERL_VERSION_EQ, PERL_VERSION_LT...
instead of a direct access to the `VERSION` macros.
@atoomic
Update Perl version to 7.1.0
b927ee9
@karenetheridge karenetheridge added the do not merge Don't merge this PR, at least for now label Aug 9, 2020
@karenetheridge karenetheridge marked this pull request as draft August 9, 2020 04:51
@wchristian
Copy link
Contributor

Why does this PR exist? People are currently imagining multiple possible reasons. Please provide an explanation of the purpose of this PR, and the full intent, not just what to the contents are meant to do.

@toddr
Copy link
Member

toddr commented Aug 15, 2020 •
edited
Loading

Why does this PR exist? People are currently imagining multiple possible reasons. Please provide an explanation of the purpose of this PR, and the full intent, not just what to the contents are meant to do.

So we can discuss and have a common place to see what's required to bump the major version.

If you look up top, you'll notice that this is a draft and cannot be merged.

@wchristian
Copy link
Contributor

Thanks for the clarification. And yeah, that was ether's action a week after opening to prevent it from being merged, but the original intent was still unclear and could have been at odds with her action. :)

@toddr
Copy link
Member

toddr commented Aug 16, 2020

Thanks for the clarification.

You're leaving me to imagine wild things now. What were some imagining the reason was?

@wchristian
Copy link
Contributor

What were some imagining the reason was?

Bump blead to 7 as soon as possible, which would be a significant stumbling block for a 5.34 release, or other development releases.

@atoomic
Copy link
Member Author

atoomic commented Aug 17, 2020

This PR was created to match the direction described by this message: https://www.nntp.perl.org/group/perl.perl5.porters/2020/07/msg258137.html

Since then a step back was performed and we are postponing the change.

@wchristian
Copy link
Contributor

Thanks a lot for clarifying. :)

@jkeenan
Copy link
Contributor

jkeenan commented Jan 26, 2021

This PR was created to match the direction described by this message: https://www.nntp.perl.org/group/perl.perl5.porters/2020/07/msg258137.html

Since then a step back was performed and we are postponing the change.

@atoomic, Given your statement above and the fact that work in this direction has stalled since the summer, I recommend closing this p.r.

Thank you very much.
Jim Keenan

@toddr toddr closed this Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tux Tux Tux left review comments

@rjbs rjbs Awaiting requested review from rjbs

@Leont Leont Awaiting requested review from Leont

@xsawyerx xsawyerx Awaiting requested review from xsawyerx

@jkeenan jkeenan Awaiting requested review from jkeenan

@toddr toddr Awaiting requested review from toddr

@khwilliamson khwilliamson Awaiting requested review from khwilliamson

@leonerd leonerd Awaiting requested review from leonerd

@lightsey lightsey Awaiting requested review from lightsey

@tonycoz tonycoz Awaiting requested review from tonycoz

Assignees
No one assigned
Labels
do not merge Don't merge this PR, at least for now hasConflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@atoomic @leonerd @wchristian @toddr @jkeenan @Tux @tonycoz @karenetheridge