ParseXS - Disable alias value collision warnings by default

We always had a bug with the value 0, when fixing it, we discovered a lot
of people were doing duplicate aliases with 0. This patch disables the warnings
except when in a special author mode, as it makes no sense to show these warnings
to end users. It would seem most times creating such aliases is not an issue and
is entirely deliberate. So showing such warnings only to module authors and only
on request also makes sense.

Author: demerphq

dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm

@@ -11,7 +11,7 @@ use Symbol;
 
 our $VERSION;
 BEGIN {
-  $VERSION = '3.48';
+  $VERSION = '3.49';
   require ExtUtils::ParseXS::Constants; ExtUtils::ParseXS::Constants->VERSION($VERSION);
   require ExtUtils::ParseXS::CountLines; ExtUtils::ParseXS::CountLines->VERSION($VERSION);
   require ExtUtils::ParseXS::Utilities; ExtUtils::ParseXS::Utilities->VERSION($VERSION);
@@ -49,6 +49,8 @@ our @EXPORT_OK = qw(
 ##############################
 # A number of "constants"
 our $DIE_ON_ERROR;
+our $AUTHOR_WARNINGS;
+$AUTHOR_WARNINGS //= ($ENV{AUTHOR_WARNINGS} || 0);
 our ($C_group_rex, $C_arg);
 # Group in C (no support for comments or literals)
 $C_group_rex = qr/ [({\[]
@@ -105,6 +107,7 @@ sub process_file {
     versioncheck    => 1,
     FH              => Symbol::gensym(),
     die_on_error    => $DIE_ON_ERROR, # if true we die() and not exit() after errors
+    author_warnings    => $AUTHOR_WARNINGS,
     %options,
   );
   $args{except} = $args{except} ? ' TRY' : '';
@@ -136,6 +139,7 @@ sub process_file {
   $self->{IncludedFiles} = {};
 
   $self->{die_on_error} = $args{die_on_error};
+  $self->{author_warnings} = $args{author_warnings};
 
   die "Missing required parameter 'filename'" unless $args{filename};
   $self->{filepathname} = $args{filename};
@@ -1372,7 +1376,10 @@ sub get_aliases {
       # yet as 0 is the default for the base function ($fname)
       push @keys, $fname
         if $value eq "0" and !defined $self->{XsubAlias}{$fname};
-      if (@keys) {
+      if (@keys and $self->{author_warnings}) {
+        # We do not warn about value collisions unless author_warnings
+        # are enabled. They aren't helpful to a module consumer, only
+        # the module author.
         @keys= map { "'$_'" }
                map { my $copy= $_;
                      $copy=~s/^$self->{Packprefix}//;

dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Constants.pm

@@ -3,7 +3,7 @@ use strict;
 use warnings;
 use Symbol;
 
-our $VERSION = '3.48';
+our $VERSION = '3.49';
 
 =head1 NAME
 

dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/CountLines.pm

@@ -1,7 +1,7 @@
 package ExtUtils::ParseXS::CountLines;
 use strict;
 
-our $VERSION = '3.48';
+our $VERSION = '3.49';
 
 our $SECTION_END_MARKER;
 

dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Eval.pm

@@ -2,7 +2,7 @@ package ExtUtils::ParseXS::Eval;
 use strict;
 use warnings;
 
-our $VERSION = '3.48';
+our $VERSION = '3.49';
 
 =head1 NAME
 

dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Utilities.pm

@@ -5,7 +5,7 @@ use Exporter;
 use File::Spec;
 use ExtUtils::ParseXS::Constants ();
 
-our $VERSION = '3.48';
+our $VERSION = '3.49';
 
 our (@ISA, @EXPORT_OK);
 @ISA = qw(Exporter);

dist/ExtUtils-ParseXS/lib/ExtUtils/Typemaps.pm

@@ -2,7 +2,7 @@ package ExtUtils::Typemaps;
 use 5.006001;
 use strict;
 use warnings;
-our $VERSION = '3.48';
+our $VERSION = '3.49';
 
 require ExtUtils::ParseXS;
 require ExtUtils::ParseXS::Constants;

dist/ExtUtils-ParseXS/lib/ExtUtils/Typemaps/Cmd.pm

@@ -2,7 +2,7 @@ package ExtUtils::Typemaps::Cmd;
 use 5.006001;
 use strict;
 use warnings;
-our $VERSION = '3.48';
+our $VERSION = '3.49';
 
 use ExtUtils::Typemaps;
 

dist/ExtUtils-ParseXS/lib/ExtUtils/Typemaps/InputMap.pm

@@ -2,7 +2,7 @@ package ExtUtils::Typemaps::InputMap;
 use 5.006001;
 use strict;
 use warnings;
-our $VERSION = '3.48';
+our $VERSION = '3.49';
 
 =head1 NAME
 

dist/ExtUtils-ParseXS/lib/ExtUtils/Typemaps/OutputMap.pm

@@ -2,7 +2,7 @@ package ExtUtils::Typemaps::OutputMap;
 use 5.006001;
 use strict;
 use warnings;
-our $VERSION = '3.48';
+our $VERSION = '3.49';
 
 =head1 NAME
 

dist/ExtUtils-ParseXS/lib/ExtUtils/Typemaps/Type.pm

@@ -4,7 +4,7 @@ use strict;
 use warnings;
 require ExtUtils::Typemaps;
 
-our $VERSION = '3.48';
+our $VERSION = '3.49';
 
 =head1 NAME