ParseXS: refactor: OUTPUT_handler(): mv to Node.pm

This is #3 of a small series of commits to refactor the OUTPUT_handler()
method and turn it into a Node subclass method.

This commit moves the ExtUtils::ParseXS methods

    OUTPUT_handler()
    OUTPUT_handler_line()

from ParseXS.pm into ParseXS/Node.pm.  For now they temporarily remain
as ExtUtils::ParseXS methods; this is just a straight cut and paste,
except for fully-qualifying the $BLOCK_regexp package variable name and
adding a couple of temporary 'package ExtUtils::ParseXS' declarations.

Author: iabyn

dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm

@@ -1743,81 +1743,6 @@ sub ST {
 }
 
 
-# Process the lines following the OUTPUT: keyword.
-
-sub OUTPUT_handler {
-  my ExtUtils::ParseXS $self = shift;
-
-  my $line = shift;
-
-  # In this loop: process each line until the next keyword or end of
-  # paragraph
-
-  for (;  $line !~ /^$BLOCK_regexp/o;  $line = shift(@{ $self->{line} })) {
-    $self->OUTPUT_handler_line($line);
-  } # foreach line in OUTPUT block
-
-  $_ = $line;
-}
-
-
-# process a single line from an OUTPUT section
-
-sub OUTPUT_handler_line {
-  my ExtUtils::ParseXS $self = shift;
-  my $line = shift;
-
-    return unless $line =~ /\S/;  # skip blank lines
-
-    if ($line =~ /^\s*SETMAGIC\s*:\s*(ENABLE|DISABLE)\s*/) {
-      $self->{xsub_SETMAGIC_state} = ($1 eq "ENABLE" ? 1 : 0);
-      return;
-    }
-
-    # Expect lines of the two forms
-    #    SomeVar
-    #    SomeVar   sv_setsv(....);
-    #
-    my ($outarg, $outcode) = $line =~ /^\s*(\S+)\s*(.*?)\s*$/s;
-
-    my ExtUtils::ParseXS::Node::Param $param =
-                                        $self->{xsub_sig}{names}{$outarg};
-
-    if ($param && $param->{in_output}) {
-      $self->blurt("Error: duplicate OUTPUT parameter '$outarg' ignored");
-      return;
-    }
-
-    if ($outarg eq "RETVAL" and $self->{xsub_seen_NO_OUTPUT}) {
-      $self->blurt("Error: can't use RETVAL in OUTPUT when NO_OUTPUT declared");
-      return;
-    }
-
-    if (   !$param  # no such param or, for RETVAL, RETVAL was void
-           # not bound to an arg which can be updated
-        or $outarg ne "RETVAL" && !$param->{arg_num})
-    {
-      $self->blurt("Error: OUTPUT $outarg not a parameter");
-      return;
-    }
-
-
-    $param->{in_output} = 1;
-    $param->{do_setmagic} = $outarg eq 'RETVAL'
-                              ? 0 # RETVAL never needs magic setting
-                              : $self->{xsub_SETMAGIC_state};
-    $param->{output_code} = $outcode if length $outcode;
-
-    if ($outarg eq 'RETVAL') {
-      # Postpone processing the RETVAL line to last (it's left to the
-      # caller to finish).
-      return;
-    }
-
-    $param->as_output_code($self);
-}
-
-
 sub FALLBACK_handler {
   my ExtUtils::ParseXS $self = shift;
   my ($setting) = @_;

dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Node.pm

@@ -3034,6 +3034,89 @@ sub as_code {
 }
 
 
+# ======================================================================
+
+package ExtUtils::ParseXS; # XXX tmp
+
+# Process the lines following the OUTPUT: keyword.
+
+sub OUTPUT_handler {
+  my ExtUtils::ParseXS $self = shift;
+
+  my $line = shift;
+
+  # In this loop: process each line until the next keyword or end of
+  # paragraph
+
+  for (;  $line !~ /^$ExtUtils::ParseXS::BLOCK_regexp/o;  $line = shift(@{ $self->{line} })) {
+    $self->OUTPUT_handler_line($line);
+  } # foreach line in OUTPUT block
+
+  $_ = $line;
+}
+
+
+# ======================================================================
+
+package ExtUtils::ParseXS; # XXX tmp
+
+# process a single line from an OUTPUT section
+
+sub OUTPUT_handler_line {
+  my ExtUtils::ParseXS $self = shift;
+  my $line = shift;
+
+    return unless $line =~ /\S/;  # skip blank lines
+
+    if ($line =~ /^\s*SETMAGIC\s*:\s*(ENABLE|DISABLE)\s*/) {
+      $self->{xsub_SETMAGIC_state} = ($1 eq "ENABLE" ? 1 : 0);
+      return;
+    }
+
+    # Expect lines of the two forms
+    #    SomeVar
+    #    SomeVar   sv_setsv(....);
+    #
+    my ($outarg, $outcode) = $line =~ /^\s*(\S+)\s*(.*?)\s*$/s;
+
+    my ExtUtils::ParseXS::Node::Param $param =
+                                        $self->{xsub_sig}{names}{$outarg};
+
+    if ($param && $param->{in_output}) {
+      $self->blurt("Error: duplicate OUTPUT parameter '$outarg' ignored");
+      return;
+    }
+
+    if ($outarg eq "RETVAL" and $self->{xsub_seen_NO_OUTPUT}) {
+      $self->blurt("Error: can't use RETVAL in OUTPUT when NO_OUTPUT declared");
+      return;
+    }
+
+    if (   !$param  # no such param or, for RETVAL, RETVAL was void
+           # not bound to an arg which can be updated
+        or $outarg ne "RETVAL" && !$param->{arg_num})
+    {
+      $self->blurt("Error: OUTPUT $outarg not a parameter");
+      return;
+    }
+
+
+    $param->{in_output} = 1;
+    $param->{do_setmagic} = $outarg eq 'RETVAL'
+                              ? 0 # RETVAL never needs magic setting
+                              : $self->{xsub_SETMAGIC_state};
+    $param->{output_code} = $outcode if length $outcode;
+
+    if ($outarg eq 'RETVAL') {
+      # Postpone processing the RETVAL line to last (it's left to the
+      # caller to finish).
+      return;
+    }
+
+    $param->as_output_code($self);
+}
+
+
 # ======================================================================