Skip to content

Commit d6371f3

Browse files
committed
generate.pl: Use 3-arg open()
Heed perlcritic/PBP
1 parent fcd5c61 commit d6371f3

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

generate.pl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ sub die_with_sample {
2626
}
2727

2828
my $yaml = do {
29-
open my $fh, "Releases.yaml" or die "Couldn't open releases";
29+
open my $fh, "<", "Releases.yaml" or die "Couldn't open releases";
3030
local $/;
3131
Load <$fh>;
3232
};
@@ -105,7 +105,7 @@ sub die_with_sample {
105105

106106
# Set up the generated DevelPatchPerl.patch
107107
{
108-
open(my $fh, ">$dir/DevelPatchPerl.patch");
108+
open my $fh, ">", "$dir/DevelPatchPerl.patch";
109109
print $fh $patch;
110110
}
111111

@@ -117,7 +117,7 @@ sub die_with_sample {
117117
die "test_parallel was provided for $release->{version} but is invalid; should be 'yes' or 'no'\n";
118118
}
119119

120-
open my $dockerfile, ">$dir/Dockerfile" or die "Couldn't open $dir/Dockerfile for writing";
120+
open my $dockerfile, ">", "$dir/Dockerfile" or die "Couldn't open $dir/Dockerfile for writing";
121121
print $dockerfile $output;
122122
close $dockerfile;
123123
}

0 commit comments

Comments
 (0)