Fix cthreads_thread_detatch returning an incorrect error code #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tripp R <60992655+RealTrippR@users.noreply.github.com>
ThePedroo
reviewed
Aug 24, 2025
| @@ -70,7 +70,7 @@ int cthreads_thread_detach(struct cthreads_thread thread) { | |||
| #endif | |||
|
|
|||
| #ifdef _WIN32 | |||
| return CloseHandle(thread.wThread); | |||
| return CloseHandle(thread.wThread)==0; | |||
There was a problem hiding this comment.
Suggested change
| return CloseHandle(thread.wThread)==0; | |
| return CloseHandle(thread.wThread) == 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for [BUG]: cthreads_thread_detach does not return 0 upon success for windows threads